Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Try to fix scheduler fixture #14557

Closed
wants to merge 1 commit into from
Closed

[WIP] Try to fix scheduler fixture #14557

wants to merge 1 commit into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jan 9, 2019

It's currently broken. Partially from #14025 but maybe there's bugs. I don't know yet.

I tried to fix it but 4 is still broken.

screen shot 2019-01-09 at 8 19 49 pm

I'm not sure if I need to change the expectations?

Also, 8 is broken but only if I go through every test before it first:

screen shot 2019-01-09 at 8 20 20 pm

It passes in isolation.

@gaearon gaearon requested a review from acdlite January 9, 2019 20:21
@bvaughn bvaughn requested review from bvaughn and removed request for bvaughn January 14, 2019 22:59
@bvaughn bvaughn mentioned this pull request Jan 14, 2019
Merged
@necolas necolas added the React Core Team Opened by a member of the React Core Team label Jan 8, 2020
@gaearon
Copy link
Collaborator Author

gaearon commented Jan 23, 2020

This might still be broken. In which case we need to revisit. Or maybe this is already fixed. I don't know.

@gaearon gaearon closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @necolas @facebook-github-bot