Fix shallow renderer set instance state after gDSFP before calling sCU #14613
+96
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think |
gaearon
approved these changes
Jan 18, 2019
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
facebook#14613) * Fix shallow renderer set instance state after gDSFP before calling sCU * Update ReactShallowRenderer.js * Unwind abstraction * Fewer names
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
facebook#14613) * Fix shallow renderer set instance state after gDSFP before calling sCU * Update ReactShallowRenderer.js * Unwind abstraction * Fewer names
This was referenced Aug 14, 2019
This was referenced Aug 24, 2019
This was referenced Aug 31, 2019
This was referenced Sep 20, 2019
Open
[Snyk] Upgrade react-dom from 16.5.2 to 16.9.0
maxiplux/spring-security-react-ant-design-polls-app#3
Open
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
…U (#14613) * Fix shallow renderer set instance state after gDSFP before calling sCU * Update ReactShallowRenderer.js * Unwind abstraction * Fewer names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #14607 which is related to enzymejs/enzyme#1970 . Before this the shallow renderer will update instance state before shouldComponentUpdate if getDeriveStateFromProps return new partial state, make the passed
nextStateand oldthis.statethe same in shouldComponentUpdate, which is different behavior with real rendering with ReactDOM.render (see the tests).