Warn when second callback is passed to setState/dispatch in Hooks #14625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Jan 18, 2019
| @@ -782,6 +782,15 @@ function dispatchAction<S, A>( | |||
| 'an infinite loop.', | |||
| ); | |||
|
|
|||
| if (__DEV__) { | |||
| warning( | |||
| arguments.length <= 3, | |||
There was a problem hiding this comment.
Could've been === 3 but I figured I don't want to punish users for our bugs.
|
ReactDOM: size: 0.0%, gzip: -0.0% Details of bundled changes.Comparing: d17d0b9...faa7bc2 react-dom
react-art
react-native-renderer
react-test-renderer
Generated by 🚫 dangerJS |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's supported in classes and not in Hooks. People try to pass it and wonder why it doesn't work. Now we warn for that. This also lets us add it (or something else) later as a second argument.