Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow reading context during useMemo etc #14653

Merged
merged 6 commits into from
Jan 23, 2019
Merged

Disallow reading context during useMemo etc #14653

merged 6 commits into from
Jan 23, 2019

Commits on Jan 21, 2019

  1. Revert "Revert "Double-render function components with Hooks in DEV i… 

    …n StrictMode" (#14652)"

This reverts commit 3fbebb2.
    @gaearon
    gaearon authored Jan 21, 2019
    Configuration menu
    Copy the full SHA
    f0129fb View commit details
    Browse the repository at this point in the history

  2. Revert "Revert "Disallow reading context during useMemo etc" (#14651)" 

    This reverts commit 5fce648.
    @gaearon
    gaearon authored Jan 21, 2019
    Configuration menu
    Copy the full SHA
    cd39503 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Add extra passing test for an edge case 

    Mentioned by @acdlite to watch out for
    @gaearon
    gaearon committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    093c8a2 View commit details
    Browse the repository at this point in the history

  2. More convoluted test

    @gaearon
    gaearon committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    7cb26fb View commit details
    Browse the repository at this point in the history

  3. Don't rely on expirationTime 

    Addresses @acdlite's concerns
    @gaearon
    gaearon committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    cfbdf90 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Edge case: forbid readContext() during eager reducer

    @gaearon
    gaearon committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    223960e View commit details
    Browse the repository at this point in the history