Avoid dynamic dispatch for scheduler calls #14968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
force-pushed
the
star-scheduler
branch
from
479f8fb
to
eee88e3
Compare
|
ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1% Details of bundled changes.Comparing: 00748c5...eee88e3 react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
|
Why did the size go up? |
|
We should track this for when we switch to ES modules though. This is a semantic bug since it passes the |
Looks like it only did for UMDs — because they already didn't suffer from this indirection. (They didn't do So in UMD the change ended up adding a few lines of junk: diff --git a/a.js b/a.js
index b714163..e4dda72 100644
--- a/a.js
+++ b/a.js
@@ -1009,7 +1009,7 @@
c = c.focusOffset;
try {
b.nodeType, e.nodeType;
- } catch (aj) {
+ } catch (lj) {
b = null;
break a;
}
@@ -5891,7 +5891,19 @@
SelectEventPlugin: Zi,
BeforeInputEventPlugin: Ki
});
- var Xc = void 0,
+ var R = da.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.Scheduler,
+ $i = R.unstable_cancelCallback,
+ aj = R.unstable_now,
+ bj = R.unstable_scheduleCallback,
+ cj = R.unstable_shouldYield,
+ dj = R.unstable_runWithPriority,
+ ej = R.unstable_getCurrentPriorityLevel,
+ fj = R.unstable_ImmediatePriority,
+ gj = R.unstable_UserBlockingPriority,
+ hj = R.unstable_NormalPriority,
+ ij = R.unstable_LowPriority,
+ jj = R.unstable_IdlePriority,
+ Xc = void 0,
Nf = (function(a) {
return "undefined" !== typeof MSApp && MSApp.execUnsafeLocalFunction
? function(b, c, d, e) {
@@ -5964,9 +5976,9 @@
strokeOpacity: !0,
strokeWidth: !0
},
- $i = ["Webkit", "ms", "Moz", "O"];
+ kj = ["Webkit", "ms", "Moz", "O"];
Object.keys(yb).forEach(function(a) {
- $i.forEach(function(b) {
+ kj.forEach(function(b) {
b = b + a.charAt(0).toUpperCase() + a.substring(1);
yb[b] = yb[a];
});
@@ -5991,18 +6003,10 @@
wbr: !0
}
),
- R = da.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.Scheduler,
- Ug = R.unstable_cancelCallback,
- te = R.unstable_now,
- Vg = R.unstable_scheduleCallback,
- Oc = R.unstable_shouldYield,
- Nc = R.unstable_runWithPriority,
- yi = R.unstable_getCurrentPriorityLevel,
- re = R.unstable_ImmediatePriority,
- se = R.unstable_UserBlockingPriority,
- Kg = R.unstable_NormalPriority,
- zi = R.unstable_LowPriority,
- Ai = R.unstable_IdlePriority,
+ te = aj,
+ Vg = bj,
+ Oc = cj,
+ Ug = $i,
me = null,
ne = null,
Di = "function" === typeof setTimeout ? setTimeout : void 0,
@@ -6324,6 +6328,13 @@
};
var ji = "function" === typeof WeakSet ? WeakSet : Set,
wi = "function" === typeof WeakMap ? WeakMap : Map,
+ yi = ej,
+ Nc = dj,
+ re = fj,
+ se = gj,
+ Kg = hj,
+ zi = ij,
+ Ai = jj,
pe = Ma.ReactCurrentDispatcher,
Jg = Ma.ReactCurrentOwner,
ye = 1073741822,The Node and WWW builds got smaller, however, as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed our prod bundles have code like:
This is because
scheduleris a CommonJS external module. Rollup calls named exports on these with dot notation. This seems very non-ideal in hot paths.I'm not sure if there's an easy way to fix it on the build level. But scheduler is the only external module we use and it's easy to fix at callsites. So I just did that. Star imports for everything else stay an anti-pattern.
This also removes some re-export junk in the UMD bundle.
Fixed version: