Swap expect(ReactNoop) for expect(Scheduler) #14971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
force-pushed
the
swapnoopforscheduler
branch
from
79e462f to
6ce727e
Compare
Details of bundled changes.Comparing: ccb2a8a...476d05f react-test-renderer
react-noop-renderer
jest-react
Generated by 🚫 dangerJS |
acdlite
force-pushed
the
swapnoopforscheduler
branch
from
6ce727e to
00b3c37
Compare
In the previous commits, I upgraded our custom Jest matchers for the noop and test renderers to use Scheduler under the hood. Now that all these matchers are using Scheduler, we can drop support for passing ReactNoop and test roots and always pass Scheduler directly.
I also noticed we don't need to regenerator runtime in noop anymore.
acdlite
force-pushed
the
swapnoopforscheduler
branch
from
00b3c37 to
476d05f
Compare
sebmarkbage
approved these changes
Feb 28, 2019
| @@ -599,7 +601,7 @@ describe('ReactIncrementalSideEffects', () => { | |||
| // render some higher priority work. The middle content will bailout so | |||
| // it remains untouched which means that it should reuse it next time. | |||
| ReactNoop.render(<Foo text="foo" step={1} />); | |||
| expect(ReactNoop).toFlushAndYield(['Foo', 'Content', 'Bar', 'Bar']); | |||
| expect(Scheduler).toFlushAndYield(['Foo', 'Content', 'Bar', 'Bar']); | |||
There was a problem hiding this comment.
This seems very confused to me because shouldComponentUpdate returns false but the renderer(ReactNoop) still chooses to render it(the Content component) which is very different to the DOM renderer, any details would you mind to share?
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* Swap expect(ReactNoop) for expect(Scheduler) In the previous commits, I upgraded our custom Jest matchers for the noop and test renderers to use Scheduler under the hood. Now that all these matchers are using Scheduler, we can drop support for passing ReactNoop and test roots and always pass Scheduler directly. * Externalize Scheduler in noop and test bundles I also noticed we don't need to regenerator runtime in noop anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous commits, I upgraded our custom Jest matchers for the noop and test renderers to use Scheduler under the hood.
Now that all these matchers are using Scheduler, we can drop support for passing ReactNoop and test roots and always pass Scheduler directly.