-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor code structure adjustments to the bundles.js file #15079
Minor code structure adjustments to the bundles.js file #15079
Conversation
@@ -434,19 +434,16 @@ const bundles = [ | |||
|
|||
/******* ESLint Plugin for Hooks (proposal) *******/ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for this change? looks like it was intended to fit under the
/******* ESLint Plugin for Hooks (proposal) *******/
title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not from me.
I executed yarn prettier
as peer pull request guidance and prettier decided to do that.
looks great. does this fix any issue opened? can get it merged faster if so |
I don't think so. It was something I stumbled on as I looked around in the source code. |
Ok it'll be up to maintainers obviously if this will get merged then. I suppose the tests ran ok as well when you ran them? |
Yes the test ran ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup!
Purpose:
Consistent code in build.js and bundles.js.
build.js destructured bundleTypes, I think bundles.js should too.
yarn prettier on the bundles.js moved stuff around.
Added deepfreeze for bundleTypes and moduleTypes
Before submitting a pull request, please make sure the following is done:
master
.yarn
in the repository root.yarn test
). Tip:yarn test --watch TestName
is helpful in development.yarn test-prod
to test in the production environment. It supports the same options asyarn test
.yarn debug-test --watch TestName
, openchrome://inspect
, and press "Inspect".yarn prettier
).yarn lint
). Tip:yarn linc
to only check changed files.yarn flow
).Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html