-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 16.8.6 #15226
Closed
Closed
React 16.8.6 #15226
Commits on Mar 27, 2019
-
Eager bailout optimization should always compare to latest reducer (f…
…acebook#15124) * Eager bailout optimization should always compare to latest reducer * queue.eagerReducer -> queue.lastRenderedReducer This name is a bit more descriptive. * Add test case that uses preceding render phase update
Configuration menu - View commit details
-
Copy full SHA for d9fa20d - Browse repository at this point
Copy the full SHA d9fa20dView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa8736a - Browse repository at this point
Copy the full SHA aa8736aView commit details -
Improve warning for invalid class contextType (facebook#15142)
* Improve warning for invalid class contextType * Don't warn for null * Grammar
Configuration menu - View commit details
-
Copy full SHA for e0c2c56 - Browse repository at this point
Copy the full SHA e0c2c56View commit details -
fix(react-dom): access iframe contentWindow instead of contentDocument (
facebook#15099) MDN has a list of methods for obtaining the window reference of an iframe: https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage#Syntax fix(react-dom): check if iframe belongs to the same origin Accessing the contentDocument of a HTMLIframeElement can cause the browser to throw, e.g. if it has a cross-origin src attribute. Safari will show an error in the console when the access results in "Blocked a frame with origin". e.g: ```javascript try { $0.contentDocument.defaultView } catch (err) { console.log('err', err) } > Blocked a frame with origin X from accessing a frame with origin Y. Protocols, domains, and ports must match. > err – TypeError: null is not an object (evaluating '$0.contentDocument.defaultView') ``` A safety way is to access one of the cross origin properties: Window or Location Which might result in "SecurityError" DOM Exception and it is compatible to Safari. ```javascript try { $0.contentWindow.location.href } catch (err) { console.log('err', err) } > err – SecurityError: Blocked a frame with origin "http://localhost:3001" from accessing a cross-origin frame. Protocols, domains, and ports must match. ``` https://html.spec.whatwg.org/multipage/browsers.html#integration-with-idl
Configuration menu - View commit details
-
Copy full SHA for f00be84 - Browse repository at this point
Copy the full SHA f00be84View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd5b895 - Browse repository at this point
Copy the full SHA cd5b895View commit details -
Configuration menu - View commit details
-
Copy full SHA for 297165f - Browse repository at this point
Copy the full SHA 297165fView commit details
Commits on Mar 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 487f4bf - Browse repository at this point
Copy the full SHA 487f4bfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.