Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writing unit tests in experimental event Drag API #15297

Merged
merged 4 commits into from
Apr 3, 2019
Merged

writing unit tests in experimental event Drag API #15297

merged 4 commits into from
Apr 3, 2019

Conversation

behzad888
Copy link
Contributor

Note: this is for an experimental event Drag API and writing tests.

  • Add onDragStart event
  • write unit tests for onDragStart, onDragEnd, onDragChange and onDragMove

@sizebot
Copy link

sizebot commented Apr 2, 2019

Details of bundled changes.

Comparing: 9307932...0a685a4

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.production.min.js 0.0% -0.2% 682 B 682 B 431 B 430 B UMD_PROD
react-events.production.min.js 0.0% -0.3% 512 B 512 B 354 B 353 B NODE_PROD
react-events-press.development.js 0.0% -0.0% 10.09 KB 10.09 KB 2.58 KB 2.58 KB UMD_DEV
react-events-press.production.min.js 0.0% -0.1% 3.97 KB 3.97 KB 1.48 KB 1.48 KB UMD_PROD
react-events-press.development.js 0.0% -0.0% 9.92 KB 9.92 KB 2.54 KB 2.54 KB NODE_DEV
react-events-hover.development.js 0.0% -0.1% 5.15 KB 5.15 KB 1.4 KB 1.39 KB UMD_DEV
react-events-hover.production.min.js 0.0% -0.2% 2.26 KB 2.26 KB 936 B 934 B UMD_PROD
react-events-hover.production.min.js 0.0% -0.1% 2.1 KB 2.1 KB 877 B 876 B NODE_PROD
react-events-focus.development.js 0.0% -0.1% 3.37 KB 3.37 KB 1.1 KB 1.1 KB UMD_DEV
react-events-focus.production.min.js 0.0% -0.1% 1.53 KB 1.53 KB 734 B 733 B UMD_PROD
react-events-focus.development.js 0.0% -0.1% 3.2 KB 3.2 KB 1.05 KB 1.05 KB NODE_DEV
react-events-focus.production.min.js 0.0% -0.1% 1.37 KB 1.37 KB 668 B 667 B NODE_PROD
react-events-swipe.development.js 0.0% -0.0% 8.29 KB 8.29 KB 2.55 KB 2.55 KB UMD_DEV
react-events-swipe.development.js 0.0% -0.0% 8.12 KB 8.12 KB 2.52 KB 2.52 KB NODE_DEV
react-events-swipe.production.min.js 0.0% -0.1% 3.29 KB 3.29 KB 1.54 KB 1.54 KB NODE_PROD
react-events-drag.development.js +3.4% +0.9% 7.56 KB 7.81 KB 2.4 KB 2.42 KB UMD_DEV
react-events-drag.production.min.js 🔺+3.4% 🔺+1.5% 3.21 KB 3.32 KB 1.46 KB 1.49 KB UMD_PROD
react-events-drag.development.js +3.4% +1.0% 7.39 KB 7.64 KB 2.37 KB 2.39 KB NODE_DEV
react-events-drag.production.min.js 🔺+3.6% 🔺+1.3% 3.04 KB 3.15 KB 1.41 KB 1.42 KB NODE_PROD
ReactEventsDrag-dev.js +5.8% +2.1% 5.57 KB 5.9 KB 1.64 KB 1.68 KB FB_WWW_DEV
ReactEventsDrag-prod.js 🔺+6.4% 🔺+2.1% 5.12 KB 5.45 KB 1.34 KB 1.36 KB FB_WWW_PROD

Generated by 🚫 dangerJS

@trueadm
Copy link
Contributor

trueadm commented Apr 2, 2019

This is good, but I feel we should probably get in #15295 first and then rebase this PR on top along with revise event Flow typings, rather than the other way around.

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. It's very much appreciated.

@trueadm trueadm merged commit 7318723 into facebook:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants