Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track Event Time as the Start Time for Suspense #15358

Merged
merged 6 commits into from
Apr 10, 2019
Merged

Track Event Time as the Start Time for Suspense #15358

merged 6 commits into from
Apr 10, 2019

Commits on Apr 10, 2019

  1. Track the earliest event time in this render 

    Rebase
    @sebmarkbage
    sebmarkbage committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    688a9b8 View commit details
    Browse the repository at this point in the history

  2. Track the time of the fallback being shown as an event time 

    When we switch back from fallback to content, we made progress and we track
the time from when we showed the fallback in the first place as the
last time we made progress.
    @sebmarkbage
    sebmarkbage committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    7b24170 View commit details
    Browse the repository at this point in the history

  3. Don't retry if synchronous

    @sebmarkbage
    sebmarkbage committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    181d6ea View commit details
    Browse the repository at this point in the history

  4. Only suspend when we switch to fallback mode 

    This ensures that we don't resuspend unnecessarily if we're just retrying
the same exact boundary again. We can still unnecessarily suspend
for nested boundaries.
    @sebmarkbage
    sebmarkbage committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    2385213 View commit details
    Browse the repository at this point in the history

  5. Rename timedOutAt to fallbackExpirationTime

    @sebmarkbage
    sebmarkbage committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    e1c473b View commit details
    Browse the repository at this point in the history

  6. Account for suspense in devtools suspense test

    @sebmarkbage
    sebmarkbage committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    b65f6a4 View commit details
    Browse the repository at this point in the history