Add support for patternUnits attribute. Fix #1535

[nhunzaker]

This fixes #1535

The patternUnits attribute defines how a pattern's coordinate system is defined (x, y, width, height). This is particularly important when using repeatable patterns in SVG. This commit adds this attribute to the lists of known properties.

I used #1487 as a reference point, please let me know if this needs to be added anywhere else.

[sophiebits]

This is actually a list of tags, not attributes -- so patternUnits shouldn't need to be here.

[nhunzaker]

Ah, I should not have been such a copy cat. I've addressed this in 81cf316

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[zpao]

Couple things:

1. patternUnits is SVG so should go in https://github.com/facebook/react/blob/master/src/browser/ui/dom/SVGDOMPropertyConfig.js
2. Since it's camelCased we'll need the extra map in DOMAttributeNames as well.
3. Please test when you've done that to ensure it works. Run grunt build and get a build of React that you can use (then make sure a change in value gets reflected).

[nhunzaker]

Went ahead and rebased master and moved everything over to SVGDOMPropertyConfig.js. I did a basic build on a current repo that uses patternUnits. Things look good, but I'll conduct some more rigorous testing tomorrow morning. JSConf calls :)

[nhunzaker]

Made a test to evaluate patternUnits here: http://www.natehunzaker.com/react-pattern-test/

If I were to add a unit test for this, where would be the best place to put it?

[zpao]

We don't actually have unit tests for these properties (one day...), so nothing to worry about there. I'm pulling in this and several other SVG related PRs today, so I'll merge this soon.

[zpao]

Thanks!

[nhunzaker]

Sweet! Very cool
On Jun 20, 2014 12:53 PM, "Paul O’Shannessy" notifications@github.com
wrote:

Thanks!

—
Reply to this email directly or view it on GitHub
#1548 (comment).