React events: fix press end event dispatching #15500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regression tests? |
Details of bundled changes.Comparing: d1f667a...f3aa134 react-events
Generated by 🚫 dangerJS |
trueadm
reviewed
Apr 25, 2019
packages/react-events/src/Press.js
Outdated
| if (pointerType === 'keyboard') { | ||
| if (!isValidKeyPress(nativeEvent.key)) { | ||
| return; | ||
| } | ||
| // If the event isn't within the event target, check if we're still within the responder region. |
There was a problem hiding this comment.
Shouldn't this be:
If the event target isn't within the press target?
trueadm
approved these changes
Apr 25, 2019
necolas
force-pushed
the
react-events/press-responder-region
branch
from
37e9737
to
de53925
Compare
|
What additional test coverage do you want? |
necolas
force-pushed
the
react-events/press-responder-region
branch
from
de53925
to
1f3a8bd
Compare
|
@necolas I see you added tests. I was probably looking at an older commit. |
This patch fixes an issue related to determining whether the end event occurs within the responder region. Previously we only checked if the event target was within the responder region for moves, otherwise we checked if the target was within the event component. Since the dimensions of the child element can change after activation, we need to recalculate the responder region before deactivation as well if the target is not within the event component.
necolas
force-pushed
the
react-events/press-responder-region
branch
from
1f3a8bd
to
f3aa134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue related to determining whether the end event occurs
within the responder region. Previously we only checked if the event target was
within the responder region for moves, otherwise we checked if the target was
within the event component. Since the dimensions of the child element can
change after activation, we need to recalculate the responder region before
deactivation as well if the target is not within the event component.
Ref #15257