-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing SVG attributes #1557
Conversation
…pacity, stroke-opacity. Fixes #1171
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Do all of these style attributes really add a lot? I ask this because we moved away from these things in HTML years ago and stuck them in |
Which attributes should be present? For example |
Hi, I see lots of PR and issues about SVG. Is there any expected version date for having these missing SVG tags/attributes support in React? |
gradientTransform: 'gradientTransform', | ||
gradientUnits: 'gradientUnits', | ||
opacity: 'opacity', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need this one since the case & spelling is identical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I removed this line when I merged it in.
Thanks! |
Added fill-opacity, font-family, font-size, opacity, stroke-opacity attributes. Fixes #1171.