Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fresh] Throw in prod and change annotation #15939

Merged
merged 3 commits into from
Jun 20, 2019
Merged

[Fresh] Throw in prod and change annotation #15939

merged 3 commits into from
Jun 20, 2019

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jun 20, 2019

  1. Babel transform now refuses to run in any environment other than development. This is to detect misconfiguration early.
  2. The runtime now throws at initialization if it's included in a production mode bundle. This should never happen and usually points at misconfiguration. I'll verify this doesn't happen in RN.
  3. Changes @hot reset annotation to @refresh reset to match overall naming.

@gaearon gaearon requested review from bvaughn and trueadm June 20, 2019 13:24
trueadm
trueadm reviewed Jun 20, 2019
View reviewed changes
packages/react-refresh/src/ReactFreshBabelPlugin.js
throw new Error(
'React Refresh Babel transform should only be enabled in development environment. ' +
'Instead, the environment is: "' +
env +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess Prettier did this, seems strange though. :/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea

@sizebot
Copy link

sizebot commented Jun 20, 2019

Details of bundled changes.

Comparing: e61c9e0...fddbb52

react-refresh

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-refresh-runtime.production.min.js -74.3% -41.2% 1.4 KB 368 B 451 B 265 B NODE_PROD
react-refresh-babel.development.js +1.4% +2.5% 21.67 KB 21.98 KB 4.65 KB 4.77 KB NODE_DEV
react-refresh-babel.production.min.js 🔺+3.3% 🔺+5.0% 6.3 KB 6.5 KB 2.17 KB 2.27 KB NODE_PROD

Generated by 🚫 dangerJS

@gaearon gaearon merged commit d4f384d into facebook:master Jun 20, 2019
@bvaughn bvaughn mentioned this pull request Jun 20, 2019
Closed
gaearon added a commit to gaearon/react that referenced this pull request Jun 24, 2019
@gaearon
[Fresh] Throw in prod and change annotation (facebook#15939)
7633487 
* Disable React Refresh Babel transform in prod

* Throw early if React Refresh runtime is imported in production

* @hot reset -> @refresh reset
rickhanlonii pushed a commit to rickhanlonii/react that referenced this pull request Jun 25, 2019
@gaearon @rickhanlonii
[Fresh] Throw in prod and change annotation (facebook#15939)
869b0c4 
* Disable React Refresh Babel transform in prod

* Throw early if React Refresh runtime is imported in production

* @hot reset -> @refresh reset
@bvaughn bvaughn mentioned this pull request Aug 19, 2019
Closed
brunolemos added a commit to brunolemos/create-snowpack-app that referenced this pull request Jun 19, 2020
@brunolemos
Update react-refresh plugin instructions to run on development only
dc132c9 
React Refresh only works on development and throws on any other environment.
It's currently making `yarn build` fail.
Ref: facebook/react#15939
@brunolemos brunolemos mentioned this pull request Jun 19, 2020
Merged
FredKSchott pushed a commit to FredKSchott/create-snowpack-app that referenced this pull request Jun 19, 2020
@brunolemos
Update react-refresh plugin instructions to run on development only (#…
bf84059 
…147)

React Refresh only works on development and throws on any other environment.
It's currently making `yarn build` fail.
Ref: facebook/react#15939
drwpow pushed a commit to FredKSchott/snowpack that referenced this pull request Jul 24, 2020
@brunolemos @drwpow
Update react-refresh plugin instructions to run on development only (#…
8b9119b 
…147)

React Refresh only works on development and throws on any other environment.
It's currently making `yarn build` fail.
Ref: facebook/react#15939
drwpow pushed a commit to FredKSchott/snowpack that referenced this pull request Jul 27, 2020
@brunolemos @drwpow
Update react-refresh plugin instructions to run on development only (#…
e186d26 
…147)

React Refresh only works on development and throws on any other environment.
It's currently making `yarn build` fail.
Ref: facebook/react#15939
drwpow pushed a commit to FredKSchott/snowpack that referenced this pull request Jul 27, 2020
@brunolemos @drwpow
Update react-refresh plugin instructions to run on development only (#…
e3546c4 
…147)

React Refresh only works on development and throws on any other environment.
It's currently making `yarn build` fail.
Ref: facebook/react#15939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

@bvaughn bvaughn Awaiting requested review from bvaughn

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @sizebot @trueadm @facebook-github-bot