Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fail] Only warn on unacted effects for strict / non sync modes #16041

Merged
merged 2 commits into from
Jul 3, 2019
Merged

[fail] Only warn on unacted effects for strict / non sync modes #16041

merged 2 commits into from
Jul 3, 2019

Commits on Jul 2, 2019

  1. only warn on unacted effects for strict / non sync modes 

    (basically, when `fiber.mode !== 0b0000`)

Warnings on unacted effects may be too noisy, especially for legacy apps. This PR fires the warning only when in a non sync mode (concurrent/batched), or when in strict mode. This should make updating easier.

I also added batched mode tests to the act() suite.
    @threepointone
    threepointone committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    4b466ce View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. explicitly check for modes before warning, explicit tests for all modes

    @threepointone
    threepointone committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    394ce77 View commit details
    Browse the repository at this point in the history