Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flare] Remove contextmenu logic from Press #16322

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Aug 8, 2019

Now we have a separate ContextMenu responder, this removes the existing logic from the Press responder.

@sizebot
Copy link

sizebot commented Aug 8, 2019

Details of bundled changes.

Comparing: 6f3c833...5c2acd8

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events-hover.development.js 0.0% -0.1% 6.77 KB 6.77 KB 1.7 KB 1.7 KB UMD_DEV
react-events-hover.production.min.js 0.0% -0.1% 3.04 KB 3.04 KB 1.21 KB 1.21 KB UMD_PROD
react-events-drag.production.min.js 0.0% -0.1% 2.48 KB 2.48 KB 1.15 KB 1.14 KB UMD_PROD
ReactEventsPress-dev.js -4.5% -3.4% 22.22 KB 21.22 KB 5.15 KB 4.97 KB FB_WWW_DEV
ReactEventsPress-prod.js -2.9% -2.4% 16.84 KB 16.35 KB 3.64 KB 3.55 KB FB_WWW_PROD
react-events-drag.development.js 0.0% -0.0% 7.7 KB 7.7 KB 2.34 KB 2.33 KB NODE_DEV
react-events-keyboard.development.js 0.0% -0.1% 4.15 KB 4.15 KB 1.59 KB 1.59 KB NODE_DEV
react-events-drag.production.min.js 0.0% -0.1% 3.12 KB 3.12 KB 1.45 KB 1.45 KB NODE_PROD
react-events-keyboard.production.min.js 0.0% -0.1% 1.7 KB 1.7 KB 961 B 960 B NODE_PROD
react-events-context-menu.development.js 0.0% -0.1% 2.69 KB 2.69 KB 1003 B 1002 B UMD_DEV
react-events-input.development.js 0.0% -0.1% 4.54 KB 4.54 KB 1.43 KB 1.43 KB UMD_DEV
react-events-input.production.min.js 0.0% -0.1% 1.82 KB 1.82 KB 973 B 972 B UMD_PROD
react-events-context-menu.development.js 0.0% -0.1% 2.5 KB 2.5 KB 958 B 957 B NODE_DEV
react-events-input.production.min.js 0.0% -0.1% 1.65 KB 1.65 KB 907 B 906 B NODE_PROD
react-events-scroll.development.js 0.0% -0.1% 5.75 KB 5.75 KB 1.54 KB 1.54 KB NODE_DEV
react-events-focus.development.js 0.0% -0.0% 10.16 KB 10.16 KB 2.12 KB 2.12 KB UMD_DEV
react-events-press.development.js -4.5% -3.2% 21.69 KB 20.72 KB 5.04 KB 4.88 KB UMD_DEV
react-events-focus.production.min.js 0.0% -0.1% 3.94 KB 3.94 KB 1.32 KB 1.32 KB UMD_PROD
react-events-press.production.min.js -2.7% -2.4% 7.09 KB 6.9 KB 2.69 KB 2.62 KB UMD_PROD
react-events-press.development.js -4.5% -3.2% 21.5 KB 20.53 KB 4.99 KB 4.83 KB NODE_DEV
react-events-focus.production.min.js 0.0% -0.1% 3.77 KB 3.77 KB 1.26 KB 1.26 KB NODE_PROD
react-events-press.production.min.js -2.8% -2.6% 6.91 KB 6.72 KB 2.63 KB 2.56 KB NODE_PROD

Generated by 🚫 dangerJS

@trueadm trueadm merged commit d9fdec6 into facebook:master Aug 8, 2019
@trueadm trueadm deleted the contextmenu-responder branch August 8, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants