Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hydration Bugfix] Updates to dehydrated content when disableSchedulerTimeoutBasedOnReactExpirationTime is enabled #16614

Closed
wants to merge 2 commits into from
Closed

[Hydration Bugfix] Updates to dehydrated content when disableSchedulerTimeoutBasedOnReactExpirationTime is enabled #16614

wants to merge 2 commits into from

Commits on Aug 29, 2019

  1. Regression test for updates to dehydrated content 

    Adds a test case for receving an update to dehydrated content when the
`disableSchedulerTimeoutBasedOnReactExpirationTime` flag is enabled.
    @acdlite
    acdlite committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    8e2dd67 View commit details
    Browse the repository at this point in the history

  2. [Scheduler] Canceling an already running task 

    Canceling an already running task is currently a no-op. It does not
cause the task to yield execution, and if the task does yield with
a continuation, then the continuation will run.

This change addresses both parts: canceling the current task causes
`shouldYield` to return `true`, and if the canceled task returns a
continuation, the continuation is ignored.

This fixes the regression test introduced in the preceding commit.
There's likely a better way to model a restart of an in-progress
render, but this approach is conceptually similar to how a regular
high priority interruption already works.
    @acdlite
    acdlite committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    83102b6 View commit details
    Browse the repository at this point in the history