Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable risky work loop changes #16771

Merged
merged 4 commits into from
Sep 13, 2019
Merged

Re-enable risky work loop changes #16771

merged 4 commits into from
Sep 13, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Sep 12, 2019 •
edited
Loading

The stack of PRs in #16743 was reverted. This adds them back.

To avoid blocking future syncs, this time I will wait until these changes land in www before merging them into the master branch. The changes are isolated to the work loop so I don't expect the temporary fork will cause conflicts.

@acdlite
Re-enable risky work loop changes
1d91c66 
The stack of PRs in facebook#16743 was reverted. This adds them back.
@sizebot
Copy link

sizebot commented Sep 12, 2019 •
edited
Loading

ReactDOM: size: 0.0%, gzip: 0.0%

Details of bundled changes.

Comparing: a7dabcb...8c3e455

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js +1.3% +1.2% 115.83 KB 117.32 KB 36.52 KB 36.96 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 142.1 KB 142.1 KB 37.12 KB 37.12 KB UMD_DEV
ReactDOM-dev.js +1.2% +1.0% 947.61 KB 958.53 KB 209.04 KB 211.04 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.8 KB 19.8 KB 7.36 KB 7.36 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 57.46 KB 57.46 KB 15.82 KB 15.82 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.3% 3.78 KB 3.78 KB 1.52 KB 1.53 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.2 KB 1.2 KB 700 B 702 B UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 55.73 KB 55.73 KB 15.49 KB 15.49 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.2% 3.61 KB 3.61 KB 1.48 KB 1.48 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.96 KB 10.96 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.04 KB 1.04 KB 631 B 633 B NODE_PROD
react-dom.development.js +1.1% +0.9% 923.37 KB 933.73 KB 208.46 KB 210.42 KB UMD_DEV
react-dom.production.min.js 🔺+1.3% 🔺+1.1% 112.27 KB 113.68 KB 36.24 KB 36.65 KB UMD_PROD
react-dom.profiling.min.js +1.3% +1.3% 115.66 KB 117.2 KB 37.17 KB 37.64 KB UMD_PROFILING
react-dom.development.js +1.1% +0.9% 917.46 KB 927.81 KB 206.85 KB 208.8 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 139.05 KB 139.05 KB 36.34 KB 36.34 KB NODE_DEV
react-dom.production.min.js 🔺+1.3% 🔺+1.1% 112.2 KB 113.61 KB 35.56 KB 35.96 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.13 KB 20.13 KB 7.5 KB 7.51 KB NODE_PROD
ReactDOM-prod.js 🔺+1.4% 🔺+1.2% 375.71 KB 381.1 KB 68.69 KB 69.51 KB FB_WWW_PROD
ReactDOM-profiling.js +1.6% +1.2% 381.19 KB 387.11 KB 69.72 KB 70.54 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 138.04 KB 138.04 KB 36.11 KB 36.11 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.73 KB 19.73 KB 7.34 KB 7.35 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.71 KB 60.71 KB 15.84 KB 15.84 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.75 KB 10.75 KB 3.67 KB 3.67 KB UMD_PROD
ReactDOMServer-dev.js 0.0% 0.0% 142.55 KB 142.55 KB 35.71 KB 35.71 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 48.58 KB 48.58 KB 11.11 KB 11.11 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.39 KB 60.39 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 3.87 KB 3.87 KB 1.51 KB 1.51 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.49 KB 10.49 KB 3.57 KB 3.57 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.5% 1.1 KB 1.1 KB 665 B 668 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +1.6% +1.3% 660.07 KB 670.4 KB 143.49 KB 145.38 KB UMD_DEV
react-art.production.min.js 🔺+1.4% 🔺+1.2% 102.02 KB 103.46 KB 31.18 KB 31.54 KB UMD_PROD
react-art.development.js +1.7% +1.5% 590.74 KB 601.07 KB 126.04 KB 127.96 KB NODE_DEV
react-art.production.min.js 🔺+2.2% 🔺+2.0% 67.02 KB 68.46 KB 20.38 KB 20.78 KB NODE_PROD
ReactART-dev.js +1.8% +1.6% 606.06 KB 616.96 KB 125.79 KB 127.77 KB FB_WWW_DEV
ReactART-prod.js 🔺+2.4% 🔺+1.9% 226.51 KB 231.92 KB 38.62 KB 39.37 KB FB_WWW_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js 🔺+2.1% 🔺+1.8% 269.86 KB 275.4 KB 46.31 KB 47.14 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +2.3% +1.9% 278.38 KB 284.67 KB 47.9 KB 48.8 KB RN_OSS_PROFILING
ReactFabric-prod.js 🔺+2.1% 🔺+1.5% 261.61 KB 267.15 KB 45.01 KB 45.71 KB RN_OSS_PROD
ReactFabric-profiling.js +2.3% +1.9% 270.47 KB 276.82 KB 46.6 KB 47.48 KB RN_OSS_PROFILING
ReactFabric-dev.js +1.5% +1.3% 745.25 KB 756.1 KB 157.33 KB 159.33 KB RN_FB_DEV
ReactFabric-prod.js 🔺+2.1% 🔺+1.5% 261.61 KB 267.16 KB 45.03 KB 45.72 KB RN_FB_PROD
ReactNativeRenderer-dev.js +1.5% +1.3% 738.64 KB 749.5 KB 156.16 KB 158.16 KB RN_OSS_DEV
ReactFabric-profiling.js +2.3% +1.9% 270.46 KB 276.82 KB 46.61 KB 47.49 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js +1.5% +1.3% 738.8 KB 749.66 KB 156.24 KB 158.24 KB RN_FB_DEV
ReactNativeRenderer-prod.js 🔺+2.1% 🔺+1.8% 269.85 KB 275.4 KB 46.32 KB 47.15 KB RN_FB_PROD
ReactNativeRenderer-profiling.js +2.3% +1.9% 278.37 KB 284.66 KB 47.91 KB 48.81 KB RN_FB_PROFILING
ReactFabric-dev.js +1.5% +1.3% 745.08 KB 755.93 KB 157.25 KB 159.25 KB RN_OSS_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js +1.8% +1.5% 617.08 KB 627.98 KB 128.2 KB 130.18 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% 0.0% 39.21 KB 39.21 KB 9.95 KB 9.96 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 11.41 KB 11.41 KB 3.53 KB 3.53 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% 0.0% 33.18 KB 33.18 KB 8.49 KB 8.49 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 11.55 KB 11.55 KB 3.62 KB 3.62 KB NODE_PROD
react-test-renderer.development.js +1.7% +1.5% 604.09 KB 614.42 KB 128.81 KB 130.74 KB UMD_DEV
react-test-renderer.production.min.js 🔺+2.1% 🔺+2.1% 68.96 KB 70.42 KB 21.16 KB 21.61 KB UMD_PROD
react-test-renderer.development.js +1.7% +1.5% 599.42 KB 609.75 KB 127.61 KB 129.55 KB NODE_DEV
react-test-renderer.production.min.js 🔺+2.1% 🔺+2.1% 68.65 KB 70.1 KB 20.88 KB 21.32 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +1.8% +1.5% 589.42 KB 599.77 KB 124.76 KB 126.68 KB NODE_DEV
react-reconciler.production.min.js 🔺+2.0% 🔺+2.0% 69.13 KB 70.54 KB 20.47 KB 20.88 KB NODE_PROD
react-reconciler-reflection.development.js 0.0% 0.0% 19.52 KB 19.52 KB 6.38 KB 6.38 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% 🔺+0.2% 2.6 KB 2.6 KB 1.16 KB 1.16 KB NODE_PROD
react-reconciler-persistent.development.js +1.8% +1.6% 586.42 KB 596.77 KB 123.5 KB 125.43 KB NODE_DEV
react-reconciler-persistent.production.min.js 🔺+2.0% 🔺+2.0% 69.14 KB 70.55 KB 20.48 KB 20.89 KB NODE_PROD

Generated by 🚫 dangerJS against 8c3e455

@acdlite
Fork root completion between sync and concurrent
01c39a1 
Lifts the switch on `workInProgressExitStatus` into
`performConcurrentWorkOnRoot` and `performSyncWorkOnRoot`.
@acdlite
Add RootLocked exit status, for createBatch API
6bd4359
@acdlite acdlite force-pushed the risky-workloop-changes branch from cd3884d to f47671e Compare September 13, 2019 00:10
@acdlite
Expired tasks should use performSyncWorkOnRoot
8c3e455 
This lets us get rid of all the `didTimeout` checks after completing
a root.
@acdlite acdlite force-pushed the risky-workloop-changes branch from f47671e to 8c3e455 Compare September 13, 2019 00:13
@acdlite acdlite marked this pull request as ready for review September 13, 2019 16:32
@acdlite acdlite merged commit 137ea78 into facebook:master Sep 13, 2019
@acdlite acdlite mentioned this pull request Jan 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acdlite @sizebot @facebook-github-bot