Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-ui] Improve consistency of Tap responder #16837

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Sep 19, 2019

Makes sure that touch events with modifier keys behave the same way as other
pointer types (i.e., does not call onTapStart if the gesture begins with a
modifier key held down)

@sizebot
Copy link

sizebot commented Sep 19, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 1d8602b

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I was thinking separately, we should probably export the properties of buttonsEnum separately rather than referencing them from an object - so we can save a few more bytes by inlining the values.

Makes sure that touch events with modifier keys behave the same way as other
pointer types (i.e., does not call `onTapStart` if the gesture begins with a
modifier key held down)
@necolas necolas force-pushed the react-ui/tap-responder-tweaks branch from 0123769 to 1d8602b Compare September 23, 2019 17:15
@necolas necolas merged commit 312b462 into facebook:master Sep 23, 2019
@necolas necolas deleted the react-ui/tap-responder-tweaks branch December 20, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants