Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enableUserBlockingEvents flag #16882

Merged
merged 1 commit into from
Sep 28, 2019

Conversation

sebmarkbage
Copy link
Collaborator

Seems like this worked out. We can clean up the flag now.

@sizebot
Copy link

sizebot commented Sep 25, 2019

ReactDOM: size: 0.0%, gzip: 0.0%

Details of bundled changes.

Comparing: 0d8c0cd...4e0d866

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js +0.1% +0.1% 120.78 KB 120.86 KB 38.02 KB 38.05 KB NODE_PROFILING
react-dom-server.browser.development.js -0.1% -0.2% 142.24 KB 142.07 KB 37.14 KB 37.05 KB UMD_DEV
ReactDOM-dev.js -0.0% -0.0% 978.71 KB 978.42 KB 216.11 KB 216.06 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.86 KB 19.86 KB 7.37 KB 7.37 KB UMD_PROD
react-dom-test-utils.development.js -0.3% -0.4% 57.53 KB 57.36 KB 15.83 KB 15.76 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.78 KB 3.78 KB 1.53 KB 1.53 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.19 KB 11.19 KB 4.16 KB 4.16 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.2 KB 1.2 KB 700 B 702 B UMD_PROD
react-dom-test-utils.development.js -0.3% -0.4% 55.81 KB 55.64 KB 15.5 KB 15.43 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.61 KB 3.61 KB 1.48 KB 1.48 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 🔺+0.1% 10.96 KB 10.96 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.04 KB 1.04 KB 632 B 633 B NODE_PROD
react-dom.development.js -0.0% -0.1% 953.57 KB 953.11 KB 215.16 KB 215.05 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 117.07 KB 117.09 KB 37.7 KB 37.72 KB UMD_PROD
react-dom.profiling.min.js 0.0% +0.1% 120.61 KB 120.63 KB 38.71 KB 38.73 KB UMD_PROFILING
react-dom.development.js -0.0% -0.1% 947.62 KB 947.16 KB 213.63 KB 213.51 KB NODE_DEV
react-dom-server.node.development.js -0.1% -0.2% 139.19 KB 139.02 KB 36.36 KB 36.29 KB NODE_DEV
react-dom.production.min.js 🔺+0.1% 0.0% 117.09 KB 117.17 KB 36.96 KB 36.97 KB NODE_PROD
ReactDOM-prod.js 0.0% 0.0% 391.82 KB 391.82 KB 71.36 KB 71.36 KB FB_WWW_PROD
react-dom-server.browser.development.js -0.1% -0.2% 138.17 KB 138 KB 36.13 KB 36.06 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.79 KB 19.79 KB 7.36 KB 7.36 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.73 KB 60.73 KB 15.85 KB 15.85 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.74 KB 10.74 KB 3.67 KB 3.67 KB UMD_PROD
ReactDOMServer-dev.js 0.0% 0.0% 142.09 KB 142.09 KB 35.6 KB 35.6 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 48.24 KB 48.24 KB 11.04 KB 11.04 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.4 KB 60.4 KB 15.72 KB 15.73 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 3.87 KB 3.87 KB 1.51 KB 1.51 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.49 KB 10.49 KB 3.57 KB 3.57 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.2% 1.1 KB 1.1 KB 666 B 667 B NODE_PROD

Generated by 🚫 dangerJS against 4e0d866

Seems like this worked out. We can clean up the flag now.
@sebmarkbage sebmarkbage force-pushed the removeuserblockingflag branch from 08da0cc to 4e0d866 Compare September 25, 2019 15:09
@sebmarkbage sebmarkbage merged commit 9d63784 into facebook:master Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants