Pass prod error messages directly to constructor #17063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I made the change to compile `invariant` to throw expressions, I left a small runtime to set the error's `name` property to "Invariant Violation" to maintain the existing behavior. I think we can remove it. The argument for keeping it is to preserve continuity in error logs, but this only affects development errors, anyway: production error messages are replaced with error codes.
Updates the `invariant` transform to pass an error message string
directly to the Error constructor, instead of mutating the
message property.
Turns this code:
```js
invariant(condition, 'A %s message that contains %s', adj, noun);
```
into this:
```js
if (!condition) {
throw Error(
__DEV__
? `A ${adj} message that contains ${noun}`
: formatProdErrorMessage(ERR_CODE, adj, noun)
);
}
```
|
React: size: -0.2%, gzip: -0.3% ReactDOM: size: -0.1%, gzip: -0.1% Details of bundled changes.Comparing: 22b2642...e0a97b5 react
react-dom
react-art
react-native-renderer
react-test-renderer
jest-react
react-reconciler
create-subscription
|
acdlite
force-pushed
the
no-mutate-error-messages
branch
from
779a164 to
e0a97b5
Compare
bvaughn
approved these changes
Oct 11, 2019
| `Minified React error #${code}; visit ${url} for the full message or ` + | ||
| 'use the non-minified dev environment for full errors and additional ' + | ||
| 'helpful warnings. '; |
There was a problem hiding this comment.
Wonder why we had a trailing space at the end before and if anything relied on it when appending to the error message. Doesn't look like it was intentional so I assume it's ok :)
There was a problem hiding this comment.
Yeah I think it was just a mistake :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
invarianttransform to pass an error message string directly to the Error constructor, instead of mutating the message property.Turns this code:
into this: