Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefixed concurrent APIs from www build #17108

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Oct 16, 2019

The downstream callers have been updated, so we can remove these.

I'll wait a few days before merging this, in case the www diffs get reverted for some reason. I think a day is fine. The sync didn't include any changes other than adding the unprefixed APIs.

The downstream callers have been updated, so we can remove these.
@sizebot
Copy link

sizebot commented Oct 16, 2019

Size changes (experimental)

Details of bundled changes.

Comparing: d7feeb2...1eed000

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.development.js 0.0% 0.0% 140.03 KB 140.03 KB 36.78 KB 36.79 KB UMD_DEV
ReactDOM-dev.js -0.0% -0.0% 968.88 KB 968.53 KB 215.42 KB 215.34 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% 0.0% 56.27 KB 56.27 KB 15.57 KB 15.58 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 🔺+0.1% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom.development.js 0.0% 0.0% 946.48 KB 946.48 KB 214.49 KB 214.5 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 118.55 KB 118.55 KB 38.12 KB 38.13 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 122.18 KB 122.18 KB 39.19 KB 39.2 KB UMD_PROFILING
react-dom.development.js 0.0% -0.0% 940.54 KB 940.54 KB 212.91 KB 212.91 KB NODE_DEV
ReactDOM-prod.js -0.1% -0.1% 398.08 KB 397.8 KB 72.46 KB 72.41 KB FB_WWW_PROD
ReactDOM-profiling.js -0.1% -0.1% 398.81 KB 398.52 KB 72.97 KB 72.92 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 135.96 KB 135.96 KB 35.79 KB 35.79 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.21 KB 20.21 KB 7.42 KB 7.43 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.14 KB 60.14 KB 15.79 KB 15.8 KB UMD_DEV
ReactDOMServer-dev.js 0.0% 0.0% 139.3 KB 139.3 KB 35.32 KB 35.33 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 59.82 KB 59.82 KB 15.66 KB 15.66 KB NODE_DEV

Generated by 🚫 dangerJS against 1eed000

@sizebot
Copy link

sizebot commented Oct 16, 2019

Size changes (stable)

Details of bundled changes.

Comparing: d7feeb2...1eed000

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.development.js 0.0% 0.0% 140 KB 140 KB 36.78 KB 36.79 KB UMD_DEV
ReactDOM-dev.js -0.0% -0.0% 968.87 KB 968.52 KB 215.42 KB 215.34 KB FB_WWW_DEV
react-dom-test-utils.production.min.js 0.0% 🔺+0.1% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 54.53 KB 54.53 KB 15.24 KB 15.24 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.94 KB 10.94 KB 4.08 KB 4.08 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 946.45 KB 946.45 KB 214.47 KB 214.47 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 115.12 KB 115.12 KB 37.1 KB 37.1 KB UMD_PROD
react-dom.development.js 0.0% 0.0% 940.52 KB 940.52 KB 212.89 KB 212.89 KB NODE_DEV
ReactDOM-prod.js -0.1% -0.1% 396.46 KB 396.18 KB 72.2 KB 72.16 KB FB_WWW_PROD
ReactDOM-profiling.js -0.1% -0.1% 397.19 KB 396.9 KB 72.71 KB 72.66 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 135.93 KB 135.93 KB 35.78 KB 35.78 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.13 KB 60.13 KB 15.79 KB 15.79 KB UMD_DEV
ReactDOMServer-prod.js 0.0% -0.0% 48.49 KB 48.49 KB 11.07 KB 11.07 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 59.8 KB 59.8 KB 15.65 KB 15.65 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.2% 1.1 KB 1.1 KB 666 B 667 B NODE_PROD

Generated by 🚫 dangerJS against 1eed000

@acdlite acdlite merged commit 7cec151 into facebook:master Oct 17, 2019
ecreeth added a commit to ecreeth/concurrent-react-notes that referenced this pull request Oct 24, 2019
- **createSyncRoot** was renamed to **createSyncRoot** in [#17165](facebook/react#17165)
- **unstable_** is not necessary in experimental releases. See [#17146](facebook/react#17146) and [#17108](facebook/react#17108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants