Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SuspenseList] Store lastEffect before rendering #17131

Merged
merged 2 commits into from
Oct 17, 2019
Merged

[SuspenseList] Store lastEffect before rendering #17131

merged 2 commits into from
Oct 17, 2019

Conversation

sebmarkbage
Copy link
Collaborator

Fixes #17128

We can't reset the effect list to null because we don't rereconcile the children so we drop deletion effects if we do that.

Instead we store the last effect as it was before we started rendering so we can go back to where it was when we reset it.

We actually already do something like this when we delete the last row for the tail="hidden" mode so we had a field available for it already.

gaearon and others added 2 commits October 17, 2019 14:54
@gaearon
Add a failing test for SuspenseList bug
8d5adb8
@sebmarkbage
Store lastEffect before rendering
b766a7b 
We can't reset the effect list to null because we don't rereconcile the
children so we drop deletion effects if we do that.

Instead we store the last effect as it was before we started rendering
so we can go back to where it was when we reset it.

We actually already do something like this when we delete the last row
for the tail="hidden" mode so we had a field available for it already.
@sizebot
Copy link

sizebot commented Oct 17, 2019

Size changes (stable)

Details of bundled changes.

Comparing: 8facc05...b766a7b

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js 0.0% 0.0% 668.11 KB 668.43 KB 145.31 KB 145.37 KB UMD_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.2% 103.68 KB 103.79 KB 31.51 KB 31.56 KB UMD_PROD
react-art.development.js +0.1% 0.0% 598.74 KB 599.06 KB 127.92 KB 127.98 KB NODE_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.1% 68.7 KB 68.8 KB 20.81 KB 20.83 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 612.02 KB 612.37 KB 127.53 KB 127.59 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.2% 🔺+0.1% 232.36 KB 232.76 KB 39.18 KB 39.21 KB FB_WWW_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js 🔺+0.3% 🔺+0.2% 272.63 KB 273.58 KB 46.75 KB 46.86 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 282.38 KB 282.48 KB 48.54 KB 48.56 KB RN_OSS_PROFILING
ReactFabric-prod.js 🔺+0.3% 🔺+0.2% 264.39 KB 265.28 KB 45.37 KB 45.44 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 275.23 KB 275.33 KB 47.29 KB 47.3 KB RN_OSS_PROFILING
ReactFabric-dev.js 0.0% 0.0% 747.39 KB 747.74 KB 158.4 KB 158.47 KB RN_FB_DEV
ReactFabric-prod.js 🔺+0.3% 🔺+0.2% 264.4 KB 265.28 KB 45.38 KB 45.45 KB RN_FB_PROD
ReactNativeRenderer-dev.js 0.0% 0.0% 741.73 KB 742.08 KB 157.48 KB 157.55 KB RN_OSS_DEV
ReactFabric-profiling.js 0.0% 0.0% 275.23 KB 275.33 KB 47.3 KB 47.31 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js 0.0% 0.0% 741.89 KB 742.24 KB 157.57 KB 157.63 KB RN_FB_DEV
ReactNativeRenderer-prod.js 🔺+0.3% 🔺+0.2% 272.63 KB 273.57 KB 46.77 KB 46.87 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 282.37 KB 282.47 KB 48.55 KB 48.57 KB RN_FB_PROFILING
ReactFabric-dev.js 0.0% 0.0% 747.22 KB 747.57 KB 158.33 KB 158.39 KB RN_OSS_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js +0.1% +0.1% 118.95 KB 119.05 KB 37.58 KB 37.61 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 968.43 KB 968.78 KB 215.26 KB 215.32 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 56.26 KB 56.26 KB 15.57 KB 15.57 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.78 KB 3.78 KB 1.53 KB 1.53 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 701 B 700 B UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 54.53 KB 54.53 KB 15.24 KB 15.24 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.61 KB 3.61 KB 1.48 KB 1.48 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.04 KB 1.04 KB 632 B 631 B NODE_PROD
react-dom.development.js 0.0% 0.0% 946.35 KB 946.68 KB 214.4 KB 214.46 KB UMD_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 115.19 KB 115.29 KB 37.14 KB 37.17 KB UMD_PROD
react-dom.profiling.min.js +0.1% 0.0% 118.71 KB 118.82 KB 38.24 KB 38.25 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 940.42 KB 940.74 KB 212.82 KB 212.87 KB NODE_DEV
react-dom-server.node.development.js 0.0% -0.0% 137.04 KB 137.04 KB 36.01 KB 36.01 KB NODE_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 115.3 KB 115.4 KB 36.56 KB 36.59 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.17 KB 20.17 KB 7.5 KB 7.5 KB NODE_PROD
ReactDOM-prod.js 🔺+0.1% 0.0% 396.24 KB 396.66 KB 72.16 KB 72.19 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 396.93 KB 397.4 KB 72.65 KB 72.7 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 135.93 KB 135.93 KB 35.78 KB 35.78 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.76 KB 19.76 KB 7.35 KB 7.35 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.13 KB 60.13 KB 15.79 KB 15.79 KB UMD_DEV
ReactDOMServer-dev.js 0.0% -0.0% 139.28 KB 139.28 KB 35.32 KB 35.32 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js +0.1% 0.0% 623.56 KB 623.91 KB 130.07 KB 130.14 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 38.56 KB 38.56 KB 9.9 KB 9.9 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 11.43 KB 11.43 KB 3.54 KB 3.54 KB UMD_PROD
react-test-renderer-shallow.production.min.js 0.0% 0.0% 11.57 KB 11.57 KB 3.63 KB 3.63 KB NODE_PROD
react-test-renderer.development.js +0.1% 0.0% 612.87 KB 613.19 KB 130.94 KB 130.99 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.1% 0.0% 70.71 KB 70.82 KB 21.66 KB 21.67 KB UMD_PROD
react-test-renderer.development.js +0.1% 0.0% 608.14 KB 608.46 KB 129.75 KB 129.81 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.1% 70.42 KB 70.52 KB 21.33 KB 21.34 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% 0.0% 599.73 KB 600.05 KB 127.09 KB 127.14 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.1% 🔺+0.1% 71.46 KB 71.57 KB 21.12 KB 21.14 KB NODE_PROD
react-reconciler-reflection.development.js 0.0% 0.0% 19.14 KB 19.14 KB 6.25 KB 6.25 KB NODE_DEV
react-reconciler-persistent.development.js +0.1% 0.0% 597.13 KB 597.45 KB 125.97 KB 126.03 KB NODE_DEV
react-reconciler-persistent.production.min.js 🔺+0.1% 🔺+0.1% 71.47 KB 71.58 KB 21.12 KB 21.14 KB NODE_PROD

Generated by 🚫 dangerJS against b766a7b

@sizebot
Copy link

sizebot commented Oct 17, 2019

Size changes (experimental)

ReactDOM: size: 0.0%, gzip: 0.0%

Details of bundled changes.

Comparing: 8facc05...b766a7b

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js 0.0% 0.0% 668.13 KB 668.46 KB 145.31 KB 145.38 KB UMD_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.1% 105.76 KB 105.86 KB 32.08 KB 32.11 KB UMD_PROD
react-art.development.js +0.1% 0.0% 598.76 KB 599.09 KB 127.92 KB 127.99 KB NODE_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.1% 70.73 KB 70.83 KB 21.26 KB 21.28 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 612.03 KB 612.38 KB 127.53 KB 127.6 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.2% 🔺+0.1% 232.38 KB 232.77 KB 39.19 KB 39.22 KB FB_WWW_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js 🔺+0.3% 🔺+0.2% 272.65 KB 273.59 KB 46.76 KB 46.87 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 282.39 KB 282.49 KB 48.54 KB 48.56 KB RN_OSS_PROFILING
ReactFabric-prod.js 🔺+0.3% 🔺+0.2% 264.41 KB 265.29 KB 45.38 KB 45.45 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 275.24 KB 275.34 KB 47.29 KB 47.31 KB RN_OSS_PROFILING
ReactFabric-dev.js 0.0% 0.0% 747.4 KB 747.75 KB 158.41 KB 158.47 KB RN_FB_DEV
ReactFabric-prod.js 🔺+0.3% 🔺+0.2% 264.41 KB 265.29 KB 45.39 KB 45.46 KB RN_FB_PROD
ReactNativeRenderer-dev.js 0.0% 0.0% 741.74 KB 742.09 KB 157.49 KB 157.55 KB RN_OSS_DEV
ReactFabric-profiling.js 0.0% 0.0% 275.24 KB 275.34 KB 47.31 KB 47.32 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js 0.0% 0.0% 741.9 KB 742.25 KB 157.57 KB 157.64 KB RN_FB_DEV
ReactNativeRenderer-prod.js 🔺+0.3% 🔺+0.2% 272.64 KB 273.58 KB 46.78 KB 46.88 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 282.38 KB 282.48 KB 48.56 KB 48.58 KB RN_FB_PROFILING
ReactFabric-dev.js 0.0% 0.0% 747.23 KB 747.58 KB 158.34 KB 158.4 KB RN_OSS_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js +0.1% +0.1% 122.49 KB 122.6 KB 38.55 KB 38.58 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 140.03 KB 140.03 KB 36.79 KB 36.79 KB UMD_DEV
ReactDOM-dev.js 0.0% 0.0% 968.45 KB 968.79 KB 215.26 KB 215.32 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.29 KB 20.29 KB 7.44 KB 7.45 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 56.27 KB 56.27 KB 15.58 KB 15.58 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.8 KB 3.8 KB 1.54 KB 1.53 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 54.54 KB 54.54 KB 15.24 KB 15.24 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.62 KB 3.62 KB 1.49 KB 1.49 KB NODE_DEV
react-dom.development.js 0.0% 0.0% 946.38 KB 946.7 KB 214.42 KB 214.48 KB UMD_DEV
react-dom.production.min.js 🔺+0.1% 0.0% 118.6 KB 118.7 KB 38.11 KB 38.12 KB UMD_PROD
react-dom.profiling.min.js +0.1% +0.1% 122.23 KB 122.33 KB 39.21 KB 39.23 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 940.44 KB 940.77 KB 212.83 KB 212.89 KB NODE_DEV
react-dom-server.node.development.js 0.0% -0.0% 137.07 KB 137.07 KB 36.01 KB 36.01 KB NODE_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 118.73 KB 118.84 KB 37.5 KB 37.53 KB NODE_PROD
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 397.86 KB 398.28 KB 72.41 KB 72.45 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 398.55 KB 399.02 KB 72.91 KB 72.96 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 135.96 KB 135.96 KB 35.79 KB 35.79 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.14 KB 60.14 KB 15.8 KB 15.8 KB UMD_DEV
ReactDOMServer-dev.js 0.0% -0.0% 139.3 KB 139.3 KB 35.33 KB 35.33 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 48.51 KB 48.51 KB 11.08 KB 11.08 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.88 KB 3.88 KB 1.52 KB 1.51 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.12 KB 1.12 KB 675 B 674 B NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js +0.1% 0.0% 623.57 KB 623.92 KB 130.08 KB 130.14 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 38.58 KB 38.58 KB 9.91 KB 9.91 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 11.44 KB 11.44 KB 3.55 KB 3.55 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% 0.0% 32.54 KB 32.54 KB 8.43 KB 8.43 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 11.58 KB 11.58 KB 3.64 KB 3.64 KB NODE_PROD
react-test-renderer.development.js +0.1% 0.0% 612.89 KB 613.22 KB 130.95 KB 131 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.1% 0.0% 70.74 KB 70.84 KB 21.67 KB 21.68 KB UMD_PROD
react-test-renderer.development.js +0.1% 0.0% 608.16 KB 608.49 KB 129.76 KB 129.82 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.1% 70.44 KB 70.55 KB 21.34 KB 21.36 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% 0.0% 599.74 KB 600.06 KB 127.09 KB 127.15 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.1% 🔺+0.1% 73.76 KB 73.86 KB 21.69 KB 21.71 KB NODE_PROD
react-reconciler-reflection.development.js 0.0% 0.0% 19.15 KB 19.15 KB 6.25 KB 6.25 KB NODE_DEV
react-reconciler-persistent.development.js +0.1% 0.0% 597.14 KB 597.47 KB 125.98 KB 126.04 KB NODE_DEV
react-reconciler-persistent.production.min.js 🔺+0.1% 🔺+0.1% 71.49 KB 71.59 KB 21.13 KB 21.15 KB NODE_PROD

Generated by 🚫 dangerJS against b766a7b

gaearon
gaearon approved these changes Oct 17, 2019
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol. Makes sense!

@sebmarkbage sebmarkbage merged commit 4eeee35 into facebook:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @sizebot @gaearon @facebook-github-bot