Dispatch commands to both UIManagers from both renderers #17211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
approved these changes
Oct 29, 2019
|
Since it is accessing the fabricUIManager directly from the global we shouldn't have any of those problems. When I forgot to do that and instead defined it at the top of the file, the tests failed. So I think this should be safe. |
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Oct 31, 2019
…ebook#17211)" This reverts commit 8eee0eb.
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Oct 31, 2019
…ebook#17211)" (facebook#17232) This reverts commit 8eee0eb.
trueadm
pushed a commit
to trueadm/react
that referenced
this pull request
Nov 4, 2019
…ebook#17211)" (facebook#17232) This reverts commit 8eee0eb.
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Jan 7, 2020
…ers (facebook#17211)" (facebook#17232)" This reverts commit d0fc0ba.
elicwhite
added a commit
that referenced
this pull request
Jan 8, 2020
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Jan 8, 2020
…ers (facebook#17211)" (facebook#17232)" (facebook#17799) * Revert "Revert "Dispatch commands to both UIManagers from both renderers (facebook#17211)" (facebook#17232)" This reverts commit d0fc0ba. * Clean up another __DEV__ warning check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactNative's internal module for
codegenNativeCommandsneeds to dispatch to Fabric or paper depending on the node it was passed.This makes the internal Renderer's exported
dispatchCommandmethod both support components created with either renderer.There was a test file
ReactFabricAndNative-test.internal.jsthat tests components created with Fabric passed to the Paper renderer.