Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call Profiler onRender when a descendant had work #17223

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Only call Profiler onRender when a descendant had work #17223

merged 1 commit into from
Oct 30, 2019

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Oct 30, 2019 •
edited
Loading

Resolves #16994

@sizebot
Copy link

sizebot commented Oct 30, 2019

Size changes (experimental)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 40700a1

@sizebot
Copy link

sizebot commented Oct 30, 2019

Size changes (stable)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 40700a1

@bvaughn bvaughn merged commit 9a35adc into facebook:master Oct 30, 2019
@bvaughn bvaughn deleted the issues/16994 branch October 30, 2019 18:08
trueadm pushed a commit to trueadm/react that referenced this pull request Nov 4, 2019
@trueadm
Only call Profiler onRender when a descendant had work (facebook#17223)
e531a4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@acdlite acdlite Awaiting requested review from acdlite

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiler calling onRender for component updates outside of the Profiler tree
4 participants
@bvaughn @sizebot @sebmarkbage @facebook-github-bot