Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove case that only exists for createBatch #17506

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Remove case that only exists for createBatch #17506

merged 1 commit into from
Dec 3, 2019

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Dec 3, 2019 •
edited
Loading

The comment says this is only needed for createBatch().commit() which doesn't exist anymore.

Ignore whitespace

@sebmarkbage sebmarkbage requested a review from acdlite December 3, 2019 02:54
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 3, 2019 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e01593f:

Sandbox Source
quirky-franklin-s7637 Configuration

@sebmarkbage
Remove case that only exists for createBatch
e01593f 
The comment says this is only needed for createBatch().commit() which
doesn't exist anymore.
@sizebot
Copy link

sizebot commented Dec 3, 2019

Details of bundled changes.

Comparing: 79572e3...e01593f

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.production.min.js -0.1% -0.1% 72.46 KB 72.42 KB 21.37 KB 21.35 KB NODE_PROD
react-reconciler-persistent.development.js -0.1% 0.0% 603.48 KB 603.12 KB 126.97 KB 127 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.1% -0.1% 72.47 KB 72.43 KB 21.38 KB 21.36 KB NODE_PROD
react-reconciler.development.js -0.1% 0.0% 606.01 KB 605.65 KB 128.09 KB 128.11 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% -0.0% 19.08 KB 19.08 KB 6.23 KB 6.23 KB NODE_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.46 KB 10.46 KB 3.57 KB 3.57 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 136.37 KB 136.37 KB 35.91 KB 35.91 KB NODE_DEV
react-dom.development.js -0.0% 0.0% 954.7 KB 954.34 KB 215.81 KB 215.83 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.85 KB 19.85 KB 7.38 KB 7.38 KB NODE_PROD
react-dom.production.min.js -0.0% -0.0% 116.27 KB 116.23 KB 37.5 KB 37.48 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 704 B 703 B UMD_PROD
react-dom.profiling.min.js -0.0% -0.0% 119.84 KB 119.79 KB 38.57 KB 38.56 KB UMD_PROFILING
react-dom.development.js -0.0% 0.0% 948.77 KB 948.41 KB 214.23 KB 214.25 KB NODE_DEV
react-dom.production.min.js -0.0% -0.0% 116.38 KB 116.34 KB 36.87 KB 36.86 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.13 KB 60.13 KB 15.79 KB 15.79 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.04 KB 1.04 KB 635 B 634 B NODE_PROD
react-dom.profiling.min.js -0.0% -0.0% 120.07 KB 120.03 KB 37.89 KB 37.88 KB NODE_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 59.8 KB 59.8 KB 15.66 KB 15.66 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.26 KB 20.26 KB 7.53 KB 7.53 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 10.94 KB 10.94 KB 4.09 KB 4.08 KB NODE_PROD
react-dom-server.browser.development.js 0.0% -0.0% 140.44 KB 140.44 KB 36.91 KB 36.91 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 691 B 690 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.1% 0.0% 674.34 KB 673.98 KB 146.28 KB 146.29 KB UMD_DEV
react-art.production.min.js -0.0% -0.0% 104.68 KB 104.64 KB 31.85 KB 31.84 KB UMD_PROD
react-art.development.js -0.1% 0.0% 604.97 KB 604.61 KB 128.88 KB 128.9 KB NODE_DEV
react-art.production.min.js -0.1% -0.0% 69.7 KB 69.65 KB 21.05 KB 21.04 KB NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.1% 0.0% 619.25 KB 618.89 KB 131.98 KB 131.99 KB UMD_DEV
react-test-renderer.production.min.js -0.1% -0.1% 71.71 KB 71.67 KB 21.95 KB 21.94 KB UMD_PROD
react-test-renderer.development.js -0.1% 0.0% 614.52 KB 614.16 KB 130.79 KB 130.8 KB NODE_DEV
react-test-renderer.production.min.js -0.1% -0.0% 71.42 KB 71.37 KB 21.57 KB 21.56 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.0% 0.0% 750.54 KB 750.16 KB 158.91 KB 158.93 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.1% 🔺+0.1% 277.48 KB 277.33 KB 47.57 KB 47.6 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.1% +0.1% 286.42 KB 286.26 KB 49.29 KB 49.32 KB RN_FB_PROFILING
ReactFabric-dev.js -0.0% 0.0% 755.96 KB 755.58 KB 159.74 KB 159.75 KB RN_FB_DEV
ReactFabric-prod.js -0.1% 🔺+0.1% 269.14 KB 268.99 KB 46.18 KB 46.2 KB RN_FB_PROD
ReactFabric-profiling.js -0.1% +0.1% 279.25 KB 279.09 KB 48.01 KB 48.04 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js -0.0% 0.0% 750.36 KB 749.99 KB 158.83 KB 158.84 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.1% 🔺+0.1% 277.09 KB 276.94 KB 47.5 KB 47.52 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.1% +0.1% 286.03 KB 285.87 KB 49.21 KB 49.25 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.0% 0.0% 755.78 KB 755.4 KB 159.66 KB 159.67 KB RN_OSS_DEV
ReactFabric-prod.js -0.1% 🔺+0.1% 268.79 KB 268.64 KB 46.1 KB 46.13 KB RN_OSS_PROD
ReactFabric-profiling.js -0.1% +0.1% 278.91 KB 278.75 KB 47.94 KB 47.97 KB RN_OSS_PROFILING

ReactDOM: size: -0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against e01593f

@sizebot
Copy link

sizebot commented Dec 3, 2019

Details of bundled changes.

Comparing: 79572e3...e01593f

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.1% 0.0% 619.27 KB 618.91 KB 131.99 KB 132 KB UMD_DEV
react-test-renderer.production.min.js -0.1% -0.1% 71.74 KB 71.69 KB 21.97 KB 21.95 KB UMD_PROD
ReactTestRenderer-dev.js -0.1% -0.0% 630.11 KB 629.72 KB 131.19 KB 131.18 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 33.07 KB 33.07 KB 8.54 KB 8.54 KB NODE_DEV
react-test-renderer.development.js -0.1% 0.0% 614.54 KB 614.18 KB 130.81 KB 130.82 KB NODE_DEV
react-test-renderer.production.min.js -0.1% -0.0% 71.44 KB 71.4 KB 21.59 KB 21.58 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-prod.js -0.1% 🔺+0.1% 269.15 KB 269 KB 46.19 KB 46.21 KB RN_FB_PROD
ReactNativeRenderer-dev.js -0.0% 0.0% 750.38 KB 750 KB 158.83 KB 158.85 KB RN_OSS_DEV
ReactFabric-profiling.js -0.1% +0.1% 279.26 KB 279.1 KB 48.02 KB 48.05 KB RN_FB_PROFILING
ReactNativeRenderer-prod.js -0.1% 🔺+0.1% 277.5 KB 277.34 KB 47.58 KB 47.61 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.1% +0.1% 286.43 KB 286.27 KB 49.29 KB 49.33 KB RN_FB_PROFILING
ReactFabric-dev.js -0.0% 0.0% 755.79 KB 755.41 KB 159.66 KB 159.68 KB RN_OSS_DEV
ReactFabric-prod.js -0.1% 🔺+0.1% 268.8 KB 268.65 KB 46.11 KB 46.14 KB RN_OSS_PROD
ReactFabric-profiling.js -0.1% +0.1% 278.92 KB 278.76 KB 47.95 KB 47.98 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.0% 0.0% 755.97 KB 755.6 KB 159.74 KB 159.76 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.1% 🔺+0.1% 277.11 KB 276.95 KB 47.51 KB 47.53 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.1% +0.1% 286.05 KB 285.89 KB 49.22 KB 49.25 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js -0.0% 0.0% 750.55 KB 750.18 KB 158.92 KB 158.93 KB RN_FB_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js -0.0% -0.0% 123.62 KB 123.58 KB 38.86 KB 38.84 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 140.46 KB 140.46 KB 36.91 KB 36.91 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 712 B 711 B UMD_PROD
ReactDOMServer-dev.js 0.0% -0.0% 139.73 KB 139.73 KB 35.46 KB 35.46 KB FB_WWW_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.05 KB 1.05 KB 643 B 642 B NODE_PROD
react-dom.development.js -0.0% 0.0% 954.72 KB 954.36 KB 215.83 KB 215.85 KB UMD_DEV
react-dom.production.min.js -0.0% -0.0% 119.68 KB 119.64 KB 38.48 KB 38.46 KB UMD_PROD
react-dom.profiling.min.js -0.0% -0.0% 123.36 KB 123.32 KB 39.56 KB 39.56 KB UMD_PROFILING
react-dom.development.js -0.0% 0.0% 948.79 KB 948.43 KB 214.25 KB 214.27 KB NODE_DEV
react-dom.production.min.js -0.0% -0.0% 119.82 KB 119.78 KB 37.81 KB 37.8 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.72 KB 20.72 KB 7.61 KB 7.61 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.14 KB 60.14 KB 15.8 KB 15.8 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.73 KB 10.73 KB 3.67 KB 3.67 KB UMD_PROD
ReactDOM-dev.js -0.0% 0.0% 976.89 KB 976.51 KB 216.77 KB 216.78 KB FB_WWW_DEV
ReactDOM-prod.js -0.0% 🔺+0.1% 403.01 KB 402.85 KB 73.41 KB 73.45 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 59.82 KB 59.82 KB 15.67 KB 15.66 KB NODE_DEV
ReactDOM-profiling.js -0.0% 0.0% 403.94 KB 403.78 KB 73.92 KB 73.95 KB FB_WWW_PROFILING
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 699 B 698 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js -0.1% -0.0% 618.43 KB 618.05 KB 128.61 KB 128.6 KB FB_WWW_DEV
ReactART-prod.js -0.1% 🔺+0.1% 236.31 KB 236.16 KB 39.83 KB 39.87 KB FB_WWW_PROD
react-art.development.js -0.1% 0.0% 674.36 KB 674 KB 146.28 KB 146.29 KB UMD_DEV
react-art.production.min.js -0.0% 0.0% 106.76 KB 106.71 KB 32.43 KB 32.43 KB UMD_PROD
react-art.development.js -0.1% 0.0% 605 KB 604.64 KB 128.89 KB 128.9 KB NODE_DEV
react-art.production.min.js -0.1% -0.1% 71.73 KB 71.68 KB 21.51 KB 21.5 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.development.js -0.1% 0.0% 603.5 KB 603.13 KB 126.98 KB 127 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% -0.0% 19.09 KB 19.09 KB 6.23 KB 6.23 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.1% -0.1% 72.49 KB 72.44 KB 21.38 KB 21.36 KB NODE_PROD
react-reconciler.development.js -0.1% 0.0% 606.02 KB 605.66 KB 128.09 KB 128.11 KB NODE_DEV
react-reconciler.production.min.js -0.1% -0.1% 74.76 KB 74.72 KB 21.92 KB 21.91 KB NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against e01593f

@sebmarkbage sebmarkbage merged commit d75323f into facebook:master Dec 3, 2019
trueadm pushed a commit to trueadm/react that referenced this pull request Dec 4, 2019
@sebmarkbage @trueadm
Remove case that only exists for createBatch (facebook#17506)
075094a 
The comment says this is only needed for createBatch().commit() which
doesn't exist anymore.
trueadm pushed a commit to trueadm/react that referenced this pull request Dec 4, 2019
@sebmarkbage @trueadm
Remove case that only exists for createBatch (facebook#17506)
b04a04c 
The comment says this is only needed for createBatch().commit() which
doesn't exist anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @sizebot @acdlite @facebook-github-bot