Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Suspense priority warning #17971

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Remove Suspense priority warning #17971

merged 2 commits into from
Feb 4, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 4, 2020

We know there are at least two bugs there:

  • It only checks the first Hook.
  • There is a DEV-only infinite loop in the class codepath because update.next can be update.

We also haven't managed to enable it yet on WWW.
Let's remove for now and revisit closer to the release.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 4, 2020
@sizebot
Copy link

sizebot commented Feb 4, 2020

Warnings
⚠️ Could not find build artifacts for base commit: 812277d

Size changes (experimental)

Generated by 🚫 dangerJS against 57dca4e

@sizebot
Copy link

sizebot commented Feb 4, 2020

Warnings
⚠️ Could not find build artifacts for base commit: 812277d

Size changes (stable)

Generated by 🚫 dangerJS against 57dca4e

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 57dca4e:

Sandbox Source
eloquent-dust-1nf1v Configuration

@gaearon gaearon merged commit d6e08fe into facebook:master Feb 4, 2020
@threepointone threepointone mentioned this pull request Feb 25, 2020
Merged
@yowainwright yowainwright mentioned this pull request Mar 6, 2020
Open
This was referenced Mar 6, 2020
Closed
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2024
Open
Open
This was referenced Sep 28, 2024
Open
Open
This was referenced Sep 29, 2024
Open
Open
This was referenced Oct 3, 2024
Open
Open
@brandonyee333 brandonyee333 mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 4, 2024
Open
Open
Open
Open
@lgdd lgdd mentioned this pull request Oct 5, 2024
Open
This was referenced Oct 5, 2024
Open
Open
This was referenced Oct 12, 2024
Open
Open
This was referenced Oct 25, 2024
Open
Open
Open
Open
This was referenced Oct 26, 2024
Open
Open
This was referenced Oct 27, 2024
Open
Open
@topolik topolik mentioned this pull request Oct 30, 2024
Open
This was referenced Nov 4, 2024
Open
Open
@snyk-kevin snyk-kevin mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

@lunaruan lunaruan Awaiting requested review from lunaruan

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @sizebot @acdlite @facebook-github-bot