Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shallow Node builds #18157

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Remove shallow Node builds #18157

merged 1 commit into from
Feb 27, 2020

Conversation

sebmarkbage
Copy link
Collaborator

This is just a forwarding module. We can hardcode it.

@sebmarkbage sebmarkbage requested a review from gaearon February 27, 2020 19:42
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 27, 2020
@sebmarkbage sebmarkbage mentioned this pull request Feb 27, 2020
Merged
@sebmarkbage sebmarkbage changed the title Remove shallow builds completely Remove shallow Node builds Feb 27, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 87d4b83:

Sandbox Source
blazing-currying-lhvjp Configuration

@sizebot
Copy link

sizebot commented Feb 27, 2020 •
edited
Loading

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against bb6a87e

@sizebot
Copy link

sizebot commented Feb 27, 2020 •
edited
Loading

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against bb6a87e

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 27, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bb6a87e:

Sandbox Source
lively-night-eh66w Configuration

@sebmarkbage
Remove Node shallow builds
bb6a87e 
This is just a forwarding module. We can hardcode it.
@NMinhNguyen
Copy link
Contributor

NMinhNguyen commented Feb 27, 2020 •
edited
Loading

I mentioned in my original PR that I didn’t bother with a UMD_PROD build in my fork, so I guess your UMD_PROD build would be a minified version of a UMD_DEV build with things like warnings and non-minified errors, but I guess that’s fine? 😅

Ignore that. It should actually be fine for the most part because Rollup will turn the ESM build into UMD.

@sebmarkbage sebmarkbage merged commit 739f20b into facebook:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NMinhNguyen NMinhNguyen NMinhNguyen approved these changes

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sebmarkbage @sizebot @NMinhNguyen @gaearon @facebook-github-bot