Fix flow types #18204
Fix flow types #18204
Conversation
facebook-github-bot
added
React Core Team
| @@ -158,7 +158,7 @@ describe('InspectedElementContext', () => { | |||
| } | |||
|
|
|||
| const ModernContext = React.createContext(); | |||
| ModernContext.displayName = 'ModernContext'; | |||
| (ModernContext: any).displayName = 'ModernContext'; | |||
There was a problem hiding this comment.
I guess I should just add displayName to our internal context type. Will do momentarily.
| event.pageY || | ||
| (event.touches && ((event: any): TouchEvent).touches[0].pageY); | ||
| (event: any).pageY || | ||
| (event.touches && (event: any).touches[0].pageY); |
There was a problem hiding this comment.
Flow v97 doesn't go very deep here I guess. 🤷♂️
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 757c6f8:
|
| @@ -3,6 +3,8 @@ | |||
| * | |||
| * This source code is licensed under the MIT license found in the | |||
| * LICENSE file in the root directory of this source tree. | |||
| * | |||
| * @flow | |||
There was a problem hiding this comment.
This was the linchpin change that uncovered all of the masked any type errors.
| @@ -37,7 +37,7 @@ function resolveDispatcher() { | |||
| export function useContext<T>( | |||
| Context: ReactContext<T>, | |||
| unstable_observedBits: number | boolean | void, | |||
| ) { | |||
| ): T { | |||
There was a problem hiding this comment.
Our internal definition of useContext was broken.
| @@ -66,6 +66,9 @@ export type ReactContext<T> = { | |||
| // DEV only | |||
| _currentRenderer?: Object | null, | |||
| _currentRenderer2?: Object | null, | |||
| // This value may be added by application code | |||
| // to improve DEV tooling display names | |||
| displayName?: string, | |||
There was a problem hiding this comment.
This helps me avoid a bunch of : any casts for DevTools code and matches the Flow definition.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 48ed4cb:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0c34969:
|
This seems to cause a parsing error. (Not sure why.) The API is deprecated anyway so I'm being lazy for now and just adding a .
|
CI failure looks unrelated... |
|
Don’t be certain that it’s unrelated, I saw this recently as a a sign that another task failed. Afk or I’d look for proof. |
|
The failure is a 401 being returned from the electron repo in its post-install task 😄 Seems unrelated. |
|
Oh no lol |
While reviewing #17934, I spotted some Flow problems that should have been caught. After investigating, this turned out to be caused by a missing
@flowpragma in the mainReact.jsfile which was causing a lot of React APIs to beanytypes for DevTools and the interactions package.