Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issue in react-devtools when highlight enabled #18498

Merged
merged 3 commits into from
Apr 6, 2020
Merged

Fix performance issue in react-devtools when highlight enabled #18498

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff6c295
Fix performance issue in react-devtools when highlight enabled
Faelivrinx Apr 5, 2020
ab6da2d
getting minimum expiration time (fix)
Faelivrinx Apr 6, 2020
c80e1b4
git pushMerge branch 'master' of github.com:facebook/react
Faelivrinx Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/react-devtools-shared/src/backend/views/TraceUpdates/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,20 +114,22 @@ function prepareToDraw(): void {
redrawTimeoutID = null;

const now = getCurrentTime();
let earliestExpiration = Number.MAX_VALUE;
let expirationTimeout = Number.NEGATIVE_INFINITY;

// Remove any items that have already expired.
nodeToData.forEach((data, node) => {
if (data.expirationTime < now) {
nodeToData.delete(node);
} else {
earliestExpiration = Math.min(earliestExpiration, data.expirationTime);
expirationTimeout = Math.max(expirationTimeout, data.expirationTime);
Faelivrinx marked this conversation as resolved.
Show resolved Hide resolved
}
});

draw(nodeToData);

redrawTimeoutID = setTimeout(prepareToDraw, earliestExpiration - now);
if (expirationTimeout > 0) {
redrawTimeoutID = setTimeout(prepareToDraw, expirationTimeout - now);
}
}

function measureNode(node: Object): Rect | null {
Expand Down