[RFC] Split react-tools out into standalone repo #1966
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to close this out regardless, but I wanted to get some feedback on the idea before I went all the way. I've been wanting to split out JSX since … forever. This finally does it but keeps it as the
react-tools
package. (ok, it's not actually moved out here, but it shows what would get moved out).I think what we could do to make sure the React repo doesn't fall out of sync is to set the dependency to the react-tools repo (presumably reactjs/react-tools). We could also then iterate in react-tools and release changes without necessarily staying strictly in sync like we do now.
I
npm link
ed and jest works, as does (at least)grunt build:basic
. The JSXTransformer build might be broken and it's also not clear where that would live (maybe it could be rebranded to ReactTools.js?)