Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Split react-tools out into standalone repo #1966

Closed
wants to merge 1 commit into from

Conversation

zpao
Copy link
Member

@zpao zpao commented Jul 31, 2014

I'm going to close this out regardless, but I wanted to get some feedback on the idea before I went all the way. I've been wanting to split out JSX since … forever. This finally does it but keeps it as the react-tools package. (ok, it's not actually moved out here, but it shows what would get moved out).

I think what we could do to make sure the React repo doesn't fall out of sync is to set the dependency to the react-tools repo (presumably reactjs/react-tools). We could also then iterate in react-tools and release changes without necessarily staying strictly in sync like we do now.

I npm linked and jest works, as does (at least) grunt build:basic. The JSXTransformer build might be broken and it's also not clear where that would live (maybe it could be rebranded to ReactTools.js?)

@sophiebits
Copy link
Collaborator

I like it.

@syranide
Copy link
Contributor

@zpao Can't we rename JSXTransformer to JSXQuickStart or something? Perhaps that would stop people using it for too long :)

Anyway, JSX is rather separate from React, AFAIK there hasn't been a single breaking change yet and unless sebmarkbage decides to change how "element factories" work, it's unlikely to happen any time soon. So keeping it separate sounds like a great idea for many reasons (especially as jsx-loader doesn't have to depend on React then, etc).

@zpao zpao closed this Oct 30, 2014
@zpao zpao deleted the standalone-react-tools branch October 30, 2014 01:08
@zpao zpao restored the standalone-react-tools branch October 30, 2014 01:08
@zpao zpao deleted the standalone-react-tools branch June 16, 2015 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants