Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate build tests to combined workflow #20574

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jan 12, 2021

Depends on #20573

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 12, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 12, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e7e36c:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jan 12, 2021

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 4e7e36c

@sizebot
Copy link

sizebot commented Jan 12, 2021

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 4e7e36c

@acdlite acdlite force-pushed the migrate-build-tests-to-combined branch 4 times, most recently from 63b9a9e to a448873 Compare January 12, 2021 06:13
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, and the status reporting looks good too:

Screen Shot 2021-01-12 at 10 05 34 AM

@acdlite acdlite force-pushed the migrate-build-tests-to-combined branch 4 times, most recently from 6bc8b59 to 4e7e36c Compare January 12, 2021 17:40
@acdlite acdlite merged commit 9a6a41d into facebook:master Jan 12, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants