Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DevTools dependency on Scheduler runWithPriority #20967

Merged

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Mar 9, 2021

Do not land before PR #20955

Should not have any observable user impact.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 9, 2021
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@sizebot
Copy link

sizebot commented Mar 9, 2021

Comparing: 73e900b...168ed43

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 123.54 kB 123.54 kB = 39.79 kB 39.79 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.07 kB 130.07 kB = 41.83 kB 41.83 kB
facebook-www/ReactDOM-prod.classic.js = 411.21 kB 411.21 kB = 76.20 kB 76.20 kB
facebook-www/ReactDOM-prod.modern.js = 399.55 kB 399.55 kB = 74.31 kB 74.31 kB
facebook-www/ReactDOMForked-prod.classic.js = 411.22 kB 411.22 kB = 76.20 kB 76.20 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 168ed43

@bvaughn
Copy link
Contributor Author

bvaughn commented Mar 9, 2021

Yup! If you think about it just ping me once you land your other PR

@rickhanlonii
Copy link
Member

@bvaughn the other PR has landed, but CI looks stuck 🤔

@bvaughn
Copy link
Contributor Author

bvaughn commented Mar 10, 2021

Thanks for the ping!

@bvaughn bvaughn merged commit ec372fa into facebook:master Mar 10, 2021
@bvaughn bvaughn deleted the devtools-remove-scheduler-runWithPriority branch March 10, 2021 13:52
dispatch(action);
startTransition(() => {
dispatch({type: 'UPDATE_INSPECTED_ELEMENT_ID'});
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. This is really much nicer. :)

koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants