Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused functions from SSR #20995

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

sebmarkbage
Copy link
Collaborator

We don't use react-id anymore.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 13, 2021
@sizebot
Copy link

sizebot commented Mar 13, 2021

Comparing: f2b6bf7...a346344

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.83 kB 122.83 kB = 39.52 kB 39.52 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.33 kB 129.33 kB = 41.59 kB 41.59 kB
facebook-www/ReactDOM-prod.classic.js = 408.70 kB 408.70 kB = 75.80 kB 75.80 kB
facebook-www/ReactDOM-prod.modern.js = 396.96 kB 396.96 kB = 73.86 kB 73.86 kB
facebook-www/ReactDOMForked-prod.classic.js = 408.71 kB 408.71 kB = 75.80 kB 75.80 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against a346344

@sebmarkbage sebmarkbage merged commit f227e7f into facebook:master Mar 13, 2021
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Mar 23, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants