Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update time-slicing demo #21401

Merged
merged 1 commit into from
May 1, 2021
Merged

Update time-slicing demo #21401

merged 1 commit into from
May 1, 2021

Conversation

rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented May 1, 2021 •
edited
Loading

Overview

This PR makes some changes to the time-slicing demo including:

  • Remove flushSync, since we flush sync by default now.
  • Switch from Scheduler to startTransition.
  • Fix some CSS issues.
  • Use an experimental React build by default.

Screen

Screen.Recording.2021-04-30.at.8.31.28.PM.mov

@rickhanlonii rickhanlonii requested a review from gaearon May 1, 2021 00:40
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 1, 2021
@sizebot
Copy link

sizebot commented May 1, 2021

Comparing: b6644fa...0764733

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.49 kB 122.49 kB = 39.38 kB 39.38 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.02 kB 129.02 kB = 41.46 kB 41.46 kB
facebook-www/ReactDOM-prod.classic.js = 406.89 kB 406.89 kB = 75.31 kB 75.31 kB
facebook-www/ReactDOM-prod.modern.js = 394.75 kB 394.75 kB = 73.35 kB 73.35 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.89 kB 406.89 kB = 75.31 kB 75.32 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0764733

@rickhanlonii rickhanlonii merged commit 79740da into facebook:master May 1, 2021
@rickhanlonii rickhanlonii deleted the rh-time-slicing branch May 1, 2021 00:51
@rickhanlonii
Copy link
Member Author

Deployed to https://react-beta-seven.vercel.app/

@gaearon gaearon mentioned this pull request May 1, 2021
Open
63 tasks
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
@rickhanlonii @koto
Update time-slicing demo (facebook#21401)
cb44442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickhanlonii @sizebot @gaearon @facebook-github-bot