Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the updater-tracking feature flag in more builds #21567

Merged
merged 1 commit into from
May 25, 2021

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented May 25, 2021

Enable the enableUpdaterTracking flag (#15658) for React Native builds and makes it a static (profiling-only) fag in www.

It was accidentally left as a dynamic flag in www even though it was turned on statically in ReactFeatureFlags.

@bvaughn bvaughn force-pushed the enable-new-profiler-apis-three branch from da8a447 to af9b0d0 Compare May 25, 2021 21:30
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 25, 2021
@sizebot
Copy link

sizebot commented May 25, 2021

Comparing: 0ae5290...af9b0d0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 126.00 kB 126.00 kB = 40.41 kB 40.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 128.82 kB 128.82 kB = 41.35 kB 41.35 kB
facebook-www/ReactDOM-prod.classic.js = 406.09 kB 406.09 kB = 75.11 kB 75.11 kB
facebook-www/ReactDOM-prod.modern.js = 394.46 kB 394.46 kB = 73.29 kB 73.29 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.09 kB 406.09 kB = 75.11 kB 75.11 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-profiling.js +1.15% 278.02 kB 281.22 kB +1.27% 49.78 kB 50.41 kB
react-native/implementations/ReactFabric-profiling.fb.js +1.15% 278.06 kB 281.26 kB +1.27% 49.76 kB 50.40 kB
react-native/implementations/ReactNativeRenderer-profiling.js +1.10% 284.97 kB 288.12 kB +1.18% 51.18 kB 51.78 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +1.10% 285.00 kB 288.15 kB +1.19% 51.17 kB 51.77 kB
react-native/implementations/ReactFabric-dev.js +0.63% 684.12 kB 688.42 kB +0.56% 148.06 kB 148.90 kB
react-native/implementations/ReactFabric-dev.fb.js +0.62% 697.39 kB 701.69 kB +0.56% 150.18 kB 151.02 kB
react-native/implementations/ReactNativeRenderer-dev.js +0.61% 702.54 kB 706.84 kB +0.56% 152.69 kB 153.55 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js +0.60% 715.78 kB 720.08 kB +0.59% 154.82 kB 155.74 kB
facebook-www/ReactTestUtils-dev.classic.js = 63.09 kB 62.93 kB = 17.37 kB 17.30 kB
facebook-www/ReactTestUtils-dev.modern.js = 63.09 kB 62.93 kB = 17.37 kB 17.31 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 42.24 kB 42.08 kB = 11.82 kB 11.76 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 42.24 kB 42.08 kB = 11.82 kB 11.76 kB
facebook-www/ReactIs-dev.classic.js = 10.17 kB 10.01 kB = 2.73 kB 2.67 kB
facebook-www/ReactIs-dev.modern.js = 10.17 kB 10.01 kB = 2.73 kB 2.67 kB

Generated by 🚫 dangerJS against af9b0d0

@bvaughn bvaughn merged commit 7841d06 into facebook:master May 25, 2021
@bvaughn bvaughn deleted the enable-new-profiler-apis-three branch May 25, 2021 21:41
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jun 7, 2021
Summary:
- **[0eea57724](facebook/react@0eea57724 )**: Fix typo in comment (accumlated → accumulated) ([#21637](facebook/react#21637)) //<ithinker5>//
- **[0706162ba](facebook/react@0706162ba )**: Fix typo in comment (environement → environment) ([#21635](facebook/react#21635)) //<niexq>//
- **[9d17b562b](facebook/react@9d17b562b )**: Fix typo in comment (satsify → satisfy) ([#21629](facebook/react#21629)) //<niexq>//
- **[b610fec00](facebook/react@b610fec00 )**: fix comments: expiration time -> lanes ([#21551](facebook/react#21551)) //<Shannon Feng>//
- **[cc4d24ab0](facebook/react@cc4d24ab0 )**: [Fizz] Always call flush() if it exists ([#21625](facebook/react#21625)) //<Dan Abramov>//
- **[e0d9b2899](facebook/react@e0d9b2899 )**: [Fizz] Minor Fixes for Warning Parity ([#21618](facebook/react#21618)) //<Sebastian Markbåge>//
- **[1b7b3592f](facebook/react@1b7b3592f )**: [Fizz] Implement Component Stacks in DEV for warnings ([#21610](facebook/react#21610)) //<Sebastian Markbåge>//
- **[39f007489](facebook/react@39f007489 )**: Make enableSuspenseLayoutEffectSemantics static for www ([#21617](facebook/react#21617)) //<Brian Vaughn>//
- **[8f3794276](facebook/react@8f3794276 )**: Prepare semver (`latest`) releases in CI ([#21615](facebook/react#21615)) //<Andrew Clark>//
- **[8b4201535](facebook/react@8b4201535 )**: Devtools: add feature to trigger an error boundary ([#21583](facebook/react#21583)) //<Bao Pham>//
- **[154a8cf32](facebook/react@154a8cf32 )**: Fix reference to wrong variable //<Andrew Clark>//
- **[6736a38b9](facebook/react@6736a38b9 )**: Add single source of truth for package versions ([#21608](facebook/react#21608)) //<Andrew Clark>//
- **[86715efa2](facebook/react@86715efa2 )**: Resolve the true entry point during tests ([#21505](facebook/react#21505)) //<Sebastian Markbåge>//
- **[a8a4742f1](facebook/react@a8a4742f1 )**: Convert ES6/TypeScript/CoffeeScript Tests to createRoot + act ([#21598](facebook/react#21598)) //<Sebastian Markbåge>//
- **[1d3558965](facebook/react@1d3558965 )**: Disable deferRenderPhaseUpdateToNextBatch by default ([#21605](facebook/react#21605)) //<Sebastian Markbåge>//
- **[a8964649b](facebook/react@a8964649b )**: Delete an unused field ([#21415](facebook/react#21415)) //<okmttdhr>//
- **[76f85b3e5](facebook/react@76f85b3e5 )**: Expose Fizz in stable builds ([#21602](facebook/react#21602)) //<Dan Abramov>//
- **[e16d61c30](facebook/react@e16d61c30 )**: [Offscreen] Mount/unmount layout effects ([#21386](facebook/react#21386)) //<Andrew Clark>//
- **[63091939b](facebook/react@63091939b )**: OSS feature flag updates ([#21597](facebook/react#21597)) //<Brian Vaughn>//
- **[efbd69b27](facebook/react@efbd69b27 )**:  Define global __WWW__ = true flag during www tests ([#21504](facebook/react#21504)) //<Sebastian Markbåge>//
- **[28625c6f4](facebook/react@28625c6f4 )**: Disable strict effects for legacy roots (again) ([#21591](facebook/react#21591)) //<Brian Vaughn>//
- **[3c2341416](facebook/react@3c2341416 )**: Update jest to v26 ([#21574](facebook/react#21574)) //<Sebastian Silbermann>//
- **[0d493dcda](facebook/react@0d493dcda )**: Removed _debugID field from Fiber - Issue #21558 ([#21570](facebook/react#21570)) //<Pulkit Sharma>//
- **[7841d0695](facebook/react@7841d0695 )**: Enable the updater-tracking feature flag in more builds ([#21567](facebook/react#21567)) //<Brian Vaughn>//
- **[6405efc36](facebook/react@6405efc36 )**: Enabled Profiling feature flags for OSS release ([#21565](facebook/react#21565)) //<Brian Vaughn>//

Changelog:
[General][Changed] - React Native sync for revisions 2d8d133...0eea577

jest_e2e[run_all_tests]

Reviewed By: bvaughn

Differential Revision: D28932083

fbshipit-source-id: 012c1bfb857ed59d7283334d633f1cce8ec50360
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants