Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devtools: add feature to trigger an error boundary #21583

Merged
merged 7 commits into from
Jun 3, 2021
Merged

Devtools: add feature to trigger an error boundary #21583

merged 7 commits into from
Jun 3, 2021

Commits on Jun 2, 2021

  1. Devtools: add feature to trigger an error boundary

    @baopham
    baopham committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    5d39e4f View commit details
    Browse the repository at this point in the history

  2. Fix not importing from ReactFiberReconciler.old

    @baopham
    baopham committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    36827a4 View commit details
    Browse the repository at this point in the history

  3. Avoid eagerly detecting whether component is error boundary and separ… 

    …ate the concepts between forced error states and console errors

With this approach, we can get rid of the warning dialog
    @baopham
    baopham committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    958b787 View commit details
    Browse the repository at this point in the history

  4. Run prettier

    @baopham
    baopham committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    e3edb36 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Rename to targetErrorBoundaryID and use getFiberIDUnsafe

    @baopham
    baopham committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    b78d210 View commit details
    Browse the repository at this point in the history

  2. Add TODO for resetting error boundary hack and move the rendererID check

    @baopham
    baopham committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    094e874 View commit details
    Browse the repository at this point in the history

  3. Added a comment to kick off CI

    Brian Vaughn committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    40d62e9 View commit details
    Browse the repository at this point in the history