Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduling Profiler: Improve warnings and add unit tests #22038

Merged
merged 7 commits into from
Aug 6, 2021
Merged

Scheduling Profiler: Improve warnings and add unit tests #22038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9f8ff66
Scheduling Profiler: Updated instructions to mentioned v18+ requirement
Aug 5, 2021
3df46e6
Moved long-event warning to post processing
Aug 6, 2021
5ebf63e
Moved long-event warning to post processing
Aug 6, 2021
6a07794
Updated nested update warning text
Aug 6, 2021
dfda376
Udpate warning about suspending outside of a transition
Aug 6, 2021
b8ce3e2
Fixed logic error in getBatchRange() with minStartTime
Aug 6, 2021
b64f88d
PR feedback: Combined a conditional statement
Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-devtools-scheduling-profiler/src/SchedulingProfiler.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
.WelcomeInstructionsListItemLink {
color: var(--color-link);
margin-left: 0.25rem;
margin-right: 0.25rem;
}

.ImportButtonLabel {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-scheduling-profiler/src/SchedulingProfiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const Welcome = ({onFileSelect}: {|onFileSelect: (file: File) => void|}) => (
target="_blank">
profiling build of ReactDOM
</a>
.
(version 18 or newer).
</li>
<li className={styles.WelcomeInstructionsListItem}>
Open the "Performance" tab in Chrome and record some performance data.
Expand Down
Loading