Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz/Flight] pipeToNodeWritable(..., writable).startWriting() -> renderToPipeableStream(...).pipe(writable) #22450

Merged
merged 6 commits into from
Oct 6, 2021
Merged

[Fizz/Flight] pipeToNodeWritable(..., writable).startWriting() -> renderToPipeableStream(...).pipe(writable) #22450

merged 6 commits into from
Oct 6, 2021

Commits on Oct 6, 2021

  1. Rename pipeToNodeWritable to renderToNodePipe

    @sebmarkbage
    sebmarkbage committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    3117d94 View commit details
    Browse the repository at this point in the history

  2. Add startWriting API to Flight 

    We don't really need it in this case because there's way less reason to
delay the stream in Flight.
    @sebmarkbage
    sebmarkbage committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    0d94381 View commit details
    Browse the repository at this point in the history

  3. Pass the destination to startWriting instead of renderToNode

    @sebmarkbage
    sebmarkbage committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    b366cab View commit details
    Browse the repository at this point in the history

  4. Rename startWriting to pipe 

    This mirrors the ReadableStream API in Node
    @sebmarkbage
    sebmarkbage committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    df7ac95 View commit details
    Browse the repository at this point in the history

  5. Error codes

    @sebmarkbage
    sebmarkbage committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    460b829 View commit details
    Browse the repository at this point in the history

  6. Rename to renderToPipeableStream 

    This mimics the renderToReadableStream API for the browser.
    @sebmarkbage
    sebmarkbage committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    a127ca0 View commit details
    Browse the repository at this point in the history