Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent errors/crashing when multiple installs of DevTools are present #22517

Merged
merged 7 commits into from
Oct 14, 2021
Merged

Prevent errors/crashing when multiple installs of DevTools are present #22517

merged 7 commits into from
Oct 14, 2021

Commits on Oct 14, 2021

  1. [DevTools] RFC: Prevent errors/crashing when multiple installations o… 

    …f DevTools
    Juan Tejada committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    0f6ee80 View commit details
    Browse the repository at this point in the history

  2. Make sure to pass the extension ID to all postMessages handled by inj… 

    …ectGlobalHook
    Juan Tejada committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    cbd76b2 View commit details
    Browse the repository at this point in the history

  3. Prefer internal version + improve handling of local dev builds 

    This commit does the following:

- Ensures that the Chrome Web Store version is disabled instead of the
internal version when duplicates are present. To do this we also rely on
the stable ID of the internal version
- It improves handling of local dev builds:
  - For dev builds, we enable the "management" permissions, so dev
  builds can easily detect duplicate extensions.
  - When a duplicate extension is detected, we disable the dev build and
  show an error so that other extensions are disabled or uninstalled. Ideally
  in this case we would disable any other extensions except the
  development one. However, since we don't have a stable extension ID for
  dev builds, doing so would require for other installations to wait for a
  message from this extension, which would unnecessarily delay initialization
  of those extensions.
    Juan Tejada committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    17dc893 View commit details
    Browse the repository at this point in the history

  4. Address comments

    Juan Tejada committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    91920c4 View commit details
    Browse the repository at this point in the history

  5. Local builds now are always enabled over duplicates, build step gener… 

    …ates stable id for local builds
    Juan Tejada committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    29549d9 View commit details
    Browse the repository at this point in the history

  6. Fix constants (remove testing ids)

    Juan Tejada committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    3a10f2c View commit details
    Browse the repository at this point in the history

  7. Comments

    Juan Tejada committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    8533ef8 View commit details
    Browse the repository at this point in the history