Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Standalone registers logger and reports logs under feature flag #22524

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

jstejada
Copy link
Contributor

@jstejada jstejada commented Oct 7, 2021

Summary

This commit implements an event logger for the standalone DevTools (react-devtools-core/standalone), which will report events that are logged from the DevTools runtime to an iframe that knows how to process those events. Note that this will only happen when the enableLogger feature flag is enabled, which will only be enabled for internal (fb-only) builds of DevTools.

How did you test this change?

  • yarn flow
  • yarn test
  • yarn test-build-devtools
  • built standalone app with enableLogger feature flag enabled and verified that logger was registered and events were correctly communicated to iframe that loads an internal endpoint.

@jstejada jstejada merged commit 5fa4d79 into facebook:main Oct 8, 2021
@jstejada jstejada deleted the logging-standalone branch October 8, 2021 12:39
@tagalong420
Copy link

You done a good job on resolving the issue an made it work like it should. Fabulous job sir.

zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants