Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't warn about concurrently rendering contexts if we finished rendering #22797

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Don't warn about concurrently rendering contexts if we finished rendering #22797

merged 5 commits into from
Jan 12, 2023
+68 −1

Commits on Jan 11, 2023

  1. Expected behavior

    @eps1lon
    eps1lon authored and Sebastian Silbermann committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    67b5c96 View commit details
    Browse the repository at this point in the history

  2. Don't warn about concurrent provider renders if we finished rendering

    @eps1lon
    eps1lon authored and Sebastian Silbermann committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    bb33098 View commit details
    Browse the repository at this point in the history

  3. Only need to reset in DEV since we only set in DEV

    @eps1lon
    eps1lon authored and Sebastian Silbermann committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    91b9705 View commit details
    Browse the repository at this point in the history

  4. Restore currentRenderN instead of resetting it

    @eps1lon
    eps1lon authored and Sebastian Silbermann committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    2ab9b80 View commit details
    Browse the repository at this point in the history

  5. Update packages/react-reconciler/src/__tests__/ReactNewContext-test.js

    @eps1lon
    eps1lon authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    4e9a32e View commit details
    Browse the repository at this point in the history