Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure react-is version used for resolution for playwright is installed #22813

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

jstejada
Copy link
Contributor

Summary

In #22790, we added a custom yarn resolution for the react-is package so that when we ran React Devtools E2E tests using playwright, we wouldn't incorrectly use the top level version of react-is in this repo (which would fail because src code hasn't undergone transpilation), and instead use the actual packaged version from npm.

However, we noticed that when trying to run an internal build of devtools we were running into the following error:

image

The reason was that the package specified in the resolutions wasn't installed at all in the repo for some reason, so yarn couldn't find it.

To fix this, this commit makes it so we always install react-is from npm via our resolutions, instead of a specific version.

How did you test this change?

  • Locally in react-devtools-inline: yarn test:e2e works now (tests are running, but they are failing on main currently)
  • Internally sync script can correctly build devtools now

@sizebot
Copy link

sizebot commented Nov 23, 2021

Comparing: 149b420...4cd099d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.98 kB 129.98 kB = 41.56 kB 41.56 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 134.74 kB 134.74 kB = 42.96 kB 42.96 kB
facebook-www/ReactDOM-prod.classic.js = 424.49 kB 424.49 kB = 78.24 kB 78.24 kB
facebook-www/ReactDOM-prod.modern.js = 413.04 kB 413.04 kB = 76.50 kB 76.50 kB
facebook-www/ReactDOMForked-prod.classic.js = 424.49 kB 424.49 kB = 78.24 kB 78.24 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4cd099d

@jstejada jstejada merged commit a04795c into facebook:main Nov 23, 2021
@jstejada jstejada deleted the react-is-resolution branch November 25, 2021 00:31
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants