Ensure react-is version used for resolution for playwright is installed #22813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #22790, we added a custom yarn resolution for the
react-is
package so that when we ran React Devtools E2E tests using playwright, we wouldn't incorrectly use the top level version ofreact-is
in this repo (which would fail because src code hasn't undergone transpilation), and instead use the actual packaged version from npm.However, we noticed that when trying to run an internal build of devtools we were running into the following error:
The reason was that the package specified in the
resolutions
wasn't installed at all in the repo for some reason, so yarn couldn't find it.To fix this, this commit makes it so we always install
react-is
from npm via ourresolutions
, instead of a specific version.How did you test this change?
react-devtools-inline
:yarn test:e2e
works now (tests are running, but they are failing on main currently)