Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored how React/DevTools log Timeline performance data #23102

Merged
merged 5 commits into from
Jan 13, 2022
Merged

Refactored how React/DevTools log Timeline performance data #23102

merged 5 commits into from
Jan 13, 2022

Commits on Jan 13, 2022

  1. Refactored how React/DevTools log Timeline performance data 

    Until now, DEV and PROFILING builds of React recorded Timeline profiling data using the User Timing V3 API. This commit changes things so that React records this data by calling methods on the DevTools hook. (For now, DevTools still records that data using the User Timing V3 API, to match previous behavior.)

This commit is mostly moving around a lot of things:
* New methods have been added to the DevTools hook (in "backend/profilingHooks") for recording the Timeline perfromance events.
* Reconciler's "ReactFiberDevToolsHook" has been updated to call these new methods (when they're present).
* User Timing method calls in "SchedulingProfiler" have been moved to DevTools "backend/profilingHooks" (to match previous behavior, for now).
* The old reconciler tests, "SchedulingProfiler-test" and "SchedulingProfilerLabels-test", have been moved into DevTools "TimelineProfiler-test".
* Two new methods have been added to the injected renderer interface: "injectProfilingHooks" and "getLaneLabelMap"
    Brian Vaughn committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    9036b1f View commit details
    Browse the repository at this point in the history

  2. Moved preprocessData-test test into react-devtools-shared folder

    Brian Vaughn committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    102538f View commit details
    Browse the repository at this point in the history

  3. Removed version-specific info from Timeline data snapshot tests

    Brian Vaughn committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    125dd4b View commit details
    Browse the repository at this point in the history

  4. Fixed ReactUpdaters test by adding missing methods to the DevTools ho… 

    …ok mock
    Brian Vaughn committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    d6fcdb7 View commit details
    Browse the repository at this point in the history

  5. Fix "Illegal invocation" error

    Brian Vaughn committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    068bfa1 View commit details
    Browse the repository at this point in the history