[fizz] Fix validateIterable call #24166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
approved these changes
Mar 25, 2022
|
Comparing: 645ec5d...a8804f0 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 12, 2022
Summary: I'm kicking this off to see what's the extent of failures we're going to get if we try to bump to React 18 inside RN OSS. This sync includes the following changes: - **[34aa5cfe0](facebook/react@34aa5cfe0 )**: Update local package.jsons for 18 //<Andrew Clark>// - **[e7d0053e6](facebook/react@e7d0053e6 )**: [fizz] Fix validateIterable call ([#24166](facebook/react#24166)) //<salazarm>// - **[6b85823b3](facebook/react@6b85823b3 )**: Clean up Selective Hydration / Event Replay flag ([#24156](facebook/react#24156)) //<salazarm>// Changelog: [General][Changed] - React Native sync for revisions 1159ff6...34aa5cf jest_e2e[run_all_tests] Reviewed By: cortinico Differential Revision: D35504622 fbshipit-source-id: ad0f6b42b6e03d78cd5d6ba51ce5a5730d25b167
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 13, 2022
* fix validate iterable call * supports iterable * gate test by experimental
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* fix validate iterable call * supports iterable * gate test by experimental
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* fix validate iterable call * supports iterable * gate test by experimental
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* fix validate iterable call * supports iterable * gate test by experimental
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* fix validate iterable call * supports iterable * gate test by experimental
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* fix validate iterable call * supports iterable * gate test by experimental
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
* fix validate iterable call * supports iterable * gate test by experimental
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: I'm kicking this off to see what's the extent of failures we're going to get if we try to bump to React 18 inside RN OSS. This sync includes the following changes: - **[34aa5cfe0](facebook/react@34aa5cfe0 )**: Update local package.jsons for 18 //<Andrew Clark>// - **[e7d0053e6](facebook/react@e7d0053e6 )**: [fizz] Fix validateIterable call ([facebook#24166](facebook/react#24166)) //<salazarm>// - **[6b85823b3](facebook/react@6b85823b3 )**: Clean up Selective Hydration / Event Replay flag ([facebook#24156](facebook/react#24156)) //<salazarm>// Changelog: [General][Changed] - React Native sync for revisions 1159ff6...34aa5cf jest_e2e[run_all_tests] Reviewed By: cortinico Differential Revision: D35504622 fbshipit-source-id: ad0f6b42b6e03d78cd5d6ba51ce5a5730d25b167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I think this was a typo?
How did you test this change?
jest