-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend attribute-behavior fixture #24947
Conversation
@@ -648,6 +648,31 @@ | |||
| `aria-=(null)`| (initial, warning)| `<null>` | | |||
| `aria-=(undefined)`| (initial, warning)| `<null>` | | |||
|
|||
## `aria-hidden` (on `<div>` inside `<div>`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shows why you should currently use <div aria-hidden={ariaHidden ? true : undefined} />
since aria-hidden="false"
is currently not recommended due to browser inconsistencies.
@@ -5323,6 +5348,31 @@ | |||
| `in=(null)`| (initial)| `<null>` | | |||
| `in=(undefined)`| (initial)| `<null>` | | |||
|
|||
## `inert` (on `<div>` inside `<div>`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shows that you should use inert={insert ? "true" ? false}
at the moment to ensure forwards compatibility at the cost of having a warning in current and future versions.
@@ -887,7 +888,7 @@ const attributes = [ | |||
read: getSVGProperty('height'), | |||
overrideStringValue: '100%', | |||
}, | |||
{name: 'hidden'}, | |||
{name: 'hidden', overrideStringValue: 'until-found'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shows that hidden="until-found"
is currently not supported.
Comparing: 0220609...4fbcf05 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
@@ -764,7 +764,7 @@ class App extends React.Component { | |||
ReactDOMStable: | |||
'https://unpkg.com/react-dom@latest/umd/react-dom.development.js', | |||
ReactDOMServerStable: | |||
'https://unpkg.com/react-dom@latest/umd/react-dom-server.browser.development.js', | |||
'https://unpkg.com/react-dom@latest/umd/react-dom-server-legacy.browser.development.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renderToString
was removed from the prior UMD build in 18.0
4fbcf05
to
9a8447a
Compare
Comparing: 64acd39...9a8447a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Replaced by #27883 |
Summary
Fix and extend attribute-behavior fixture (to help test #24741 or #24730).
How did you test this change?