Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend attribute-behavior fixture #24947

Closed
wants to merge 5 commits into from

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jul 17, 2022

Summary

Fix and extend attribute-behavior fixture (to help test #24741 or #24730).

How did you test this change?

  • Updated snapshot table using Chrome Version 103.0.5060.114 (Official Build) (64-bit)

@eps1lon eps1lon changed the title Test hidden="until-found" Extend attribute-behavior fixture Jul 17, 2022
@@ -648,6 +648,31 @@
| `aria-=(null)`| (initial, warning)| `<null>` |
| `aria-=(undefined)`| (initial, warning)| `<null>` |

## `aria-hidden` (on `<div>` inside `<div>`)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows why you should currently use <div aria-hidden={ariaHidden ? true : undefined} /> since aria-hidden="false" is currently not recommended due to browser inconsistencies.

@@ -5323,6 +5348,31 @@
| `in=(null)`| (initial)| `<null>` |
| `in=(undefined)`| (initial)| `<null>` |

## `inert` (on `<div>` inside `<div>`)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shows that you should use inert={insert ? "true" ? false} at the moment to ensure forwards compatibility at the cost of having a warning in current and future versions.

@@ -887,7 +888,7 @@ const attributes = [
read: getSVGProperty('height'),
overrideStringValue: '100%',
},
{name: 'hidden'},
{name: 'hidden', overrideStringValue: 'until-found'},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shows that hidden="until-found" is currently not supported.

@sizebot
Copy link

sizebot commented Jul 17, 2022

Comparing: 0220609...4fbcf05

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 133.01 kB 133.01 kB = 42.65 kB 42.65 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 138.23 kB 138.23 kB = 44.15 kB 44.15 kB
facebook-www/ReactDOM-prod.classic.js = 468.56 kB 468.56 kB = 84.30 kB 84.31 kB
facebook-www/ReactDOM-prod.modern.js = 453.80 kB 453.80 kB = 82.07 kB 82.07 kB
facebook-www/ReactDOMForked-prod.classic.js = 468.56 kB 468.56 kB = 84.30 kB 84.31 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4fbcf05

@@ -764,7 +764,7 @@ class App extends React.Component {
ReactDOMStable:
'https://unpkg.com/react-dom@latest/umd/react-dom.development.js',
ReactDOMServerStable:
'https://unpkg.com/react-dom@latest/umd/react-dom-server.browser.development.js',
'https://unpkg.com/react-dom@latest/umd/react-dom-server-legacy.browser.development.js',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renderToString was removed from the prior UMD build in 18.0

@eps1lon eps1lon marked this pull request as ready for review July 17, 2022 17:40
@eps1lon eps1lon force-pushed the test/attributes-spec branch from 4fbcf05 to 9a8447a Compare February 11, 2023 11:23
@react-sizebot
Copy link

Comparing: 64acd39...9a8447a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.54 kB 154.54 kB = 48.83 kB 48.83 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.54 kB 156.54 kB = 49.45 kB 49.45 kB
facebook-www/ReactDOM-prod.classic.js = 529.73 kB 529.73 kB = 94.36 kB 94.36 kB
facebook-www/ReactDOM-prod.modern.js = 514.95 kB 514.95 kB = 92.17 kB 92.17 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 9a8447a

@eps1lon
Copy link
Collaborator Author

eps1lon commented Feb 18, 2024

Replaced by #27883

@eps1lon eps1lon closed this Feb 18, 2024
@eps1lon eps1lon deleted the test/attributes-spec branch February 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants