Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue add end-of-frame scheduling for default events #25310

Closed
wants to merge 6 commits into from
Closed

Continue add end-of-frame scheduling for default events #25310

wants to merge 6 commits into from

Conversation

tyao1
Copy link
Contributor

@tyao1 tyao1 commented Sep 22, 2022 •
edited
Loading

Continue #24594

Added:

  • Address TODOs
  • Also make all DefaultUpdates use rAF

@tyao1 tyao1 requested a review from acdlite September 22, 2022 00:07
@tyao1 tyao1 marked this pull request as draft September 22, 2022 00:07
@sizebot
Copy link

sizebot commented Sep 27, 2022 •
edited
Loading

Comparing: cb5084d...a6c5974

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.16% 135.28 kB 135.49 kB +0.19% 43.39 kB 43.47 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.64% 142.74 kB 143.66 kB +0.59% 45.58 kB 45.85 kB
facebook-www/ReactDOM-prod.classic.js +0.69% 490.70 kB 494.08 kB +0.68% 87.32 kB 87.92 kB
facebook-www/ReactDOM-prod.modern.js +0.71% 475.99 kB 479.37 kB +0.77% 85.13 kB 85.78 kB
facebook-www/ReactDOMForked-prod.classic.js +0.69% 490.70 kB 494.08 kB +0.68% 87.32 kB 87.92 kB
oss-experimental/jest-react/cjs/jest-react.production.min.js +6.77% 2.42 kB 2.59 kB +3.42% 1.17 kB 1.21 kB
oss-stable-semver/jest-react/cjs/jest-react.production.min.js +6.77% 2.42 kB 2.59 kB +3.42% 1.17 kB 1.21 kB
oss-stable/jest-react/cjs/jest-react.production.min.js +6.77% 2.42 kB 2.59 kB +3.42% 1.17 kB 1.21 kB
oss-experimental/jest-react/cjs/jest-react.development.js +2.61% 10.61 kB 10.89 kB +1.49% 3.75 kB 3.80 kB
oss-stable-semver/jest-react/cjs/jest-react.development.js +2.61% 10.61 kB 10.89 kB +1.49% 3.75 kB 3.80 kB
oss-stable/jest-react/cjs/jest-react.development.js +2.61% 10.61 kB 10.89 kB +1.49% 3.75 kB 3.80 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/jest-react/cjs/jest-react.production.min.js +6.77% 2.42 kB 2.59 kB +3.42% 1.17 kB 1.21 kB
oss-stable-semver/jest-react/cjs/jest-react.production.min.js +6.77% 2.42 kB 2.59 kB +3.42% 1.17 kB 1.21 kB
oss-stable/jest-react/cjs/jest-react.production.min.js +6.77% 2.42 kB 2.59 kB +3.42% 1.17 kB 1.21 kB
oss-experimental/jest-react/cjs/jest-react.development.js +2.61% 10.61 kB 10.89 kB +1.49% 3.75 kB 3.80 kB
oss-stable-semver/jest-react/cjs/jest-react.development.js +2.61% 10.61 kB 10.89 kB +1.49% 3.75 kB 3.80 kB
oss-stable/jest-react/cjs/jest-react.development.js +2.61% 10.61 kB 10.89 kB +1.49% 3.75 kB 3.80 kB
facebook-www/ReactIs-dev.modern.js +0.78% 9.62 kB 9.70 kB +0.47% 2.54 kB 2.55 kB
facebook-www/ReactIs-dev.classic.js +0.78% 9.62 kB 9.70 kB +0.47% 2.54 kB 2.55 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.72% 12.43 kB 12.52 kB +0.51% 3.72 kB 3.74 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.72% 12.43 kB 12.52 kB +0.51% 3.72 kB 3.74 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.72% 12.43 kB 12.52 kB +0.51% 3.72 kB 3.74 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.72% 12.50 kB 12.59 kB +0.48% 3.74 kB 3.75 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.72% 12.50 kB 12.59 kB +0.48% 3.74 kB 3.75 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.72% 12.50 kB 12.59 kB +0.48% 3.74 kB 3.75 kB
facebook-www/ReactDOM-prod.modern.js +0.71% 475.99 kB 479.37 kB +0.77% 85.13 kB 85.78 kB
facebook-www/ReactDOMForked-prod.modern.js +0.71% 475.99 kB 479.37 kB +0.77% 85.13 kB 85.78 kB
facebook-www/ReactDOM-prod.classic.js +0.69% 490.70 kB 494.08 kB +0.68% 87.32 kB 87.92 kB
facebook-www/ReactDOMForked-prod.classic.js +0.69% 490.70 kB 494.08 kB +0.68% 87.32 kB 87.92 kB
facebook-www/ReactDOM-profiling.modern.js +0.69% 505.81 kB 509.27 kB +0.72% 89.66 kB 90.30 kB
facebook-www/ReactDOMForked-profiling.modern.js +0.69% 505.81 kB 509.27 kB +0.72% 89.66 kB 90.30 kB
facebook-www/ReactDOM-profiling.classic.js +0.66% 520.58 kB 524.04 kB +0.66% 91.90 kB 92.50 kB
facebook-www/ReactDOMForked-profiling.classic.js +0.66% 520.58 kB 524.04 kB +0.66% 91.90 kB 92.50 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.64% 142.74 kB 143.66 kB +0.59% 45.58 kB 45.85 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.min.js +0.63% 146.09 kB 147.01 kB +0.61% 46.98 kB 47.27 kB
oss-experimental/react-dom/cjs/react-dom.profiling.min.js +0.60% 152.22 kB 153.14 kB +0.56% 47.97 kB 48.24 kB
oss-experimental/react-dom/umd/react-dom.production.min.js +0.54% 142.78 kB 143.56 kB +0.68% 46.25 kB 46.57 kB
oss-experimental/react-dom/umd/react-dom.profiling.min.js +0.51% 151.59 kB 152.37 kB +0.67% 48.54 kB 48.86 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +0.49% 280.47 kB 281.84 kB +0.42% 49.71 kB 49.92 kB
facebook-www/ReactART-prod.modern.js +0.48% 317.11 kB 318.63 kB +0.51% 54.25 kB 54.52 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +0.47% 296.05 kB 297.43 kB +0.42% 52.06 kB 52.28 kB
facebook-www/ReactART-prod.classic.js +0.46% 327.88 kB 329.40 kB +0.47% 56.05 kB 56.32 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js +0.43% 103.27 kB 103.72 kB +0.43% 31.64 kB 31.78 kB
react-native/implementations/ReactFabric-prod.js +0.41% 308.59 kB 309.86 kB +0.41% 54.68 kB 54.91 kB
facebook-www/ReactART-dev.modern.js +0.40% 846.03 kB 849.43 kB +0.33% 178.74 kB 179.33 kB
react-native/implementations/ReactFabric-prod.fb.js +0.40% 316.95 kB 318.22 kB +0.39% 56.33 kB 56.55 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js +0.40% 112.12 kB 112.57 kB +0.43% 33.73 kB 33.88 kB
facebook-www/ReactART-dev.classic.js +0.40% 856.25 kB 859.66 kB +0.32% 180.81 kB 181.39 kB
react-native/implementations/ReactFabric-profiling.js +0.39% 327.68 kB 328.95 kB +0.38% 57.81 kB 58.03 kB
react-native/implementations/ReactNativeRenderer-prod.js +0.39% 315.37 kB 316.59 kB +0.37% 55.76 kB 55.97 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js +0.38% 323.71 kB 324.93 kB +0.37% 57.42 kB 57.63 kB
facebook-www/ReactDOMForked-dev.modern.js +0.38% 1,220.05 kB 1,224.63 kB +0.30% 267.31 kB 268.11 kB
facebook-www/ReactDOM-dev.modern.js +0.38% 1,220.05 kB 1,224.63 kB +0.30% 267.31 kB 268.12 kB
react-native/implementations/ReactFabric-profiling.fb.js +0.37% 343.60 kB 344.88 kB +0.38% 60.46 kB 60.69 kB
facebook-www/ReactDOMForked-dev.classic.js +0.37% 1,243.68 kB 1,248.26 kB +0.30% 271.60 kB 272.42 kB
facebook-www/ReactDOM-dev.classic.js +0.37% 1,243.68 kB 1,248.26 kB +0.30% 271.60 kB 272.42 kB
react-native/implementations/ReactNativeRenderer-profiling.js +0.36% 334.54 kB 335.76 kB +0.35% 58.87 kB 59.08 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +0.35% 350.45 kB 351.67 kB +0.35% 61.54 kB 61.75 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.development.js +0.34% 34.60 kB 34.72 kB +0.33% 7.80 kB 7.83 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.development.js +0.34% 34.60 kB 34.72 kB +0.33% 7.80 kB 7.83 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.development.js +0.34% 34.60 kB 34.72 kB +0.33% 7.80 kB 7.83 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.34% 34.73 kB 34.85 kB +0.33% 7.82 kB 7.84 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.34% 34.73 kB 34.85 kB +0.33% 7.82 kB 7.84 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.34% 34.73 kB 34.85 kB +0.33% 7.82 kB 7.84 kB
facebook-www/ReactDOMTesting-prod.modern.js +0.33% 437.44 kB 438.91 kB +0.31% 80.71 kB 80.95 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js +0.33% 1,088.10 kB 1,091.71 kB +0.28% 243.43 kB 244.11 kB
oss-experimental/react-dom/cjs/react-dom.development.js +0.33% 1,105.05 kB 1,108.66 kB +0.27% 247.05 kB 247.71 kB
facebook-www/ReactDOMTesting-prod.classic.js +0.32% 453.43 kB 454.89 kB +0.33% 83.11 kB 83.38 kB
oss-experimental/react-dom/umd/react-dom.development.js +0.32% 1,159.13 kB 1,162.83 kB +0.27% 249.79 kB 250.46 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js +0.31% 820.84 kB 823.37 kB +0.21% 174.57 kB 174.94 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.min.js +0.24% 96.44 kB 96.68 kB +0.29% 29.65 kB 29.74 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.min.js +0.24% 96.47 kB 96.70 kB +0.29% 29.67 kB 29.76 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.23% 750.52 kB 752.28 kB +0.16% 160.77 kB 161.04 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.23% 750.52 kB 752.28 kB +0.16% 160.77 kB 161.04 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.23% 730.88 kB 732.54 kB +0.16% 156.71 kB 156.96 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.min.js +0.22% 105.27 kB 105.51 kB +0.24% 31.85 kB 31.93 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js +0.22% 105.30 kB 105.53 kB +0.24% 31.88 kB 31.95 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.22% 779.38 kB 781.08 kB +0.16% 166.39 kB 166.65 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.22% 779.40 kB 781.11 kB +0.16% 166.41 kB 166.68 kB
oss-stable-semver/react-art/cjs/react-art.production.min.js +0.22% 85.12 kB 85.31 kB +0.23% 26.46 kB 26.52 kB
oss-stable/react-art/cjs/react-art.production.min.js +0.22% 85.15 kB 85.33 kB +0.23% 26.46 kB 26.52 kB
oss-experimental/react-art/cjs/react-art.production.min.js +0.21% 91.63 kB 91.82 kB +0.20% 28.23 kB 28.28 kB
react-native/implementations/ReactFabric-dev.js +0.20% 808.72 kB 810.36 kB +0.15% 175.57 kB 175.82 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.min.js +0.20% 92.41 kB 92.59 kB +0.16% 28.50 kB 28.55 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.min.js +0.20% 92.43 kB 92.62 kB +0.16% 28.50 kB 28.55 kB

Generated by 🚫 dangerJS against a6c5974

@tyao1 tyao1 marked this pull request as ready for review September 27, 2022 01:22
@tyao1
Copy link
Contributor Author

tyao1 commented Sep 28, 2022

I have a commit ready to update the isUnknownEventPriority to an enum. @acdlite should I create a new PR or include it in this one?

@tyao1 tyao1 mentioned this pull request Sep 30, 2022
Closed
tyao1
tyao1 commented Oct 5, 2022
View reviewed changes
packages/react-dom/src/__tests__/ReactDOMFiberAsync-test.js Outdated
@@ -730,7 +730,7 @@ describe('ReactDOMFiberAsync', () => {
});

// @gate enableFrameEndScheduling || !allowConcurrentByDefault
it('When allowConcurrentByDefault is enabled, unknown updates should not be time sliced', () => {
it.skip('When allowConcurrentByDefault is enabled, unknown updates should not be time sliced', () => {
Copy link
Contributor Author

@tyao1 tyao1 Oct 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we would need to differ default and unknown updates in this case now that default is also rAF, and when update is default and allowConcurrentByDefault is enabled, updates should still be time sliced?

This was referenced Oct 11, 2022
Closed
Closed
@tyao1
Copy link
Contributor Author

tyao1 commented Oct 12, 2022

Resubmitted in #25467

@tyao1 tyao1 closed this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tyao1 @sizebot @facebook-github-bot @rickhanlonii