Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow upgrade to 0.143 #25408

Merged
merged 1 commit into from
Oct 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"eslint-plugin-react-internal": "link:./scripts/eslint-rules",
"fbjs-scripts": "1.2.0",
"filesize": "^6.0.1",
"flow-bin": "^0.142.0",
"flow-bin": "^0.143.0",
"glob": "^7.1.6",
"glob-stream": "^6.1.0",
"google-closure-compiler": "^20200517.0.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/react-dom/src/server/ReactDOMFizzServerBrowser.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ function renderToReadableStream(
const stream: ReactDOMServerReadableStream = (new ReadableStream(
{
type: 'bytes',
pull(controller): ?Promise<void> {
pull: (controller): ?Promise<void> => {
startFlowing(request, controller);
},
cancel(reason): ?Promise<void> {
cancel: (reason): ?Promise<void> => {
abort(request);
},
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react-dom/src/server/ReactDOMFizzStaticBrowser.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function prerender(
const stream = new ReadableStream(
{
type: 'bytes',
pull(controller): ?Promise<void> {
pull: (controller): ?Promise<void> => {
startFlowing(request, controller);
},
},
Expand Down
10 changes: 5 additions & 5 deletions packages/react-reconciler/src/ReactStrictModeWarnings.new.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ type FiberArray = Array<Fiber>;
type FiberToFiberComponentsMap = Map<Fiber, FiberArray>;

const ReactStrictModeWarnings = {
recordUnsafeLifecycleWarnings(fiber: Fiber, instance: any): void {},
flushPendingUnsafeLifecycleWarnings(): void {},
recordLegacyContextWarning(fiber: Fiber, instance: any): void {},
flushLegacyContextWarning(): void {},
discardPendingWarnings(): void {},
recordUnsafeLifecycleWarnings: (fiber: Fiber, instance: any): void => {},
flushPendingUnsafeLifecycleWarnings: (): void => {},
recordLegacyContextWarning: (fiber: Fiber, instance: any): void => {},
flushLegacyContextWarning: (): void => {},
discardPendingWarnings: (): void => {},
};

if (__DEV__) {
Expand Down
10 changes: 5 additions & 5 deletions packages/react-reconciler/src/ReactStrictModeWarnings.old.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ type FiberArray = Array<Fiber>;
type FiberToFiberComponentsMap = Map<Fiber, FiberArray>;

const ReactStrictModeWarnings = {
recordUnsafeLifecycleWarnings(fiber: Fiber, instance: any): void {},
flushPendingUnsafeLifecycleWarnings(): void {},
recordLegacyContextWarning(fiber: Fiber, instance: any): void {},
flushLegacyContextWarning(): void {},
discardPendingWarnings(): void {},
recordUnsafeLifecycleWarnings: (fiber: Fiber, instance: any): void => {},
flushPendingUnsafeLifecycleWarnings: (): void => {},
recordLegacyContextWarning: (fiber: Fiber, instance: any): void => {},
flushLegacyContextWarning: (): void => {},
discardPendingWarnings: (): void => {},
};

if (__DEV__) {
Expand Down
12 changes: 5 additions & 7 deletions packages/react-refresh/src/ReactFreshRuntime.js
Original file line number Diff line number Diff line change
Expand Up @@ -460,20 +460,18 @@ export function injectIntoGlobalHook(globalObject: any): void {
globalObject.__REACT_DEVTOOLS_GLOBAL_HOOK__ = hook = {
renderers: new Map(),
supportsFiber: true,
inject(injected) {
return nextID++;
},
onScheduleFiberRoot(
inject: injected => nextID++,
onScheduleFiberRoot: (
id: number,
root: FiberRoot,
children: ReactNodeList,
) {},
onCommitFiberRoot(
) => {},
onCommitFiberRoot: (
id: number,
root: FiberRoot,
maybePriorityLevel: mixed,
didError: boolean,
) {},
) => {},
onCommitFiberUnmount() {},
};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ function renderToReadableStream(
const stream = new ReadableStream(
{
type: 'bytes',
start(controller): ?Promise<void> {
start: (controller): ?Promise<void> => {
startWork(request);
},
pull(controller): ?Promise<void> {
pull: (controller): ?Promise<void> => {
startFlowing(request, controller);
},
cancel(reason): ?Promise<void> {},
cancel: (reason): ?Promise<void> => {},
},
// $FlowFixMe size() methods are not allowed on byte streams.
{highWaterMark: 0},
Expand Down
4 changes: 1 addition & 3 deletions scripts/flow/config/flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,9 @@ esproposal.class_instance_fields=enable
esproposal.optional_chaining=enable
exact_by_default=true
munge_underscores=false
types_first=true
well_formed_exports=true

# Substituted by createFlowConfig.js:
%REACT_RENDERER_FLOW_OPTIONS%

[version]
^0.142.0
^0.143.0
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7911,10 +7911,10 @@ flatted@^2.0.0:
resolved "https://registry.yarnpkg.com/flatted/-/flatted-2.0.2.tgz#4575b21e2bcee7434aa9be662f4b7b5f9c2b5138"
integrity sha512-r5wGx7YeOwNWNlCA0wQ86zKyDLMQr+/RB8xy74M4hTphfmjlijTSSXGuH8rnvKZnfT9i+75zmd8jcKdMR4O6jA==

flow-bin@^0.142.0:
version "0.142.0"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.142.0.tgz#b46b69de1123cf7c5a50917402968e07291df054"
integrity sha512-YgiapK/wrJjcgSgOWfoncbZ4vZrZWdHs+p7V9duI9zo4ehW2nM/VRrpSaWoZ+CWu3t+duGyAvupJvC6MM2l07w==
flow-bin@^0.143.0:
version "0.143.1"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.143.1.tgz#2ff825dfd85e84531b0ae780842cb1c2a9743cd2"
integrity sha512-6S6bgZ/pghBzEUELXkwFH/bsHT+GBMo8ftHDYs0SSJ+1e6NRdFfqxcYhaTvAK8zteSfQLZBIoec6G4WPPp4qQg==

fluent-syntax@0.13.0:
version "0.13.0"
Expand Down