Flow: run codemod to remove existential type #25416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existential type `*` was deprecated and a codemod provided to replace it. Ran that and did some manual fixups: ```sh node_modules/.bin/flow codemod replace-existentials --write . ``` [ghstack-poisoned]
This was referenced Oct 4, 2022
Merged
Merged
Merged
Closed
facebook-github-bot
added
the
React Core Team
kassens
added a commit
to kassens/react
that referenced
this pull request
Oct 4, 2022
The existential type `*` was deprecated and a codemod provided to replace it. Ran that and did some manual fixups: ```sh node_modules/.bin/flow codemod replace-existentials --write . ``` ghstack-source-id: 0d970f838bcef5df40041b6d612915211d94b3cf Pull Request resolved: facebook#25416
gaearon
approved these changes
Oct 4, 2022
|
Comparing: 3fd9bd8...4ba0662 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
The existential type `*` was deprecated and a codemod provided to replace it. Ran that and did some manual fixups: ```sh node_modules/.bin/flow codemod replace-existentials --write . ``` [ghstack-poisoned]
kassens
added a commit
that referenced
this pull request
Oct 4, 2022
The existential type `*` was deprecated and a codemod provided to replace it. Ran that and did some manual fixups: ```sh node_modules/.bin/flow codemod replace-existentials --write . ``` ghstack-source-id: 4c98b8db6a80159aa6ba3f2fc3659c11939da134 Pull Request resolved: #25416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The existential type
*was deprecated and a codemod provided to replace it. Ran that and did some manual fixups:node_modules/.bin/flow codemod replace-existentials --write .