support title as a singleton #25507
Closed
support title as a singleton #25507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnoff
commented
Oct 18, 2022
| ); | ||
| } | ||
| // This will initialize a title element if it didn't already exist | ||
| ownerDocument.title = ownerDocument.title; |
There was a problem hiding this comment.
this may be too cute and also, mutates more than necessary. not sure if browsers are smart and noop when not changed. either way I could rewrite to be more conventional about constructing a title if missing. unlike the other singletons we cannot expect the document to always contain one
|
Comparing: 9cdf8a9...71d1960 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
liking the resource approach better... #25508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds title as a singleton type.
treats singletons as containers for purposes of removal
modifies the removal pathway to guard against already removed children when removing from a container
todo:
support out of position hydration
relax validation to support out of position rendering